[ReplicatedLoglet] Implement remote sequencer find tail #2017
+774
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2024
muhamadazmy
force-pushed
the
pr2017
branch
8 times, most recently
from
1c84db6
to
148b191
Compare
Summary: Implements a remote loglet append calls to leader sequencer
tillrohrmann
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Thanks for creating this PR @muhamadazmy. What happens if we lose the GetSequencerInfo or its response?
Comment on lines
+232
to
+243
| .call( | ||
| &self.networking, | ||
| self.params.sequencer, | ||
| GetSequencerInfo { | ||
| header: CommonRequestHeader { | ||
| log_id: self.log_id, | ||
| loglet_id: self.params.loglet_id, | ||
| segment_index: self.segment_index, | ||
| }, | ||
| }, | ||
| ) | ||
| .await |
There was a problem hiding this comment.
What happens if the request or response get lost? Would sync_sequencer_tail get stuck?
| ); | ||
| } | ||
| _ => { | ||
| unreachable!() |
There was a problem hiding this comment.
Maybe state why this case is unreachable. Maybe also don't use the wildcard. That way we'll see the places where a newly SequencerStatus variant needs to be handled.
Comment on lines
+277
to
+279
| async fn sync_log_servers_tail(&self) -> Result<(), OperationError> { | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
That's where #2019 comes into play, right?
Comment on lines
+218
to
+224
| if self.sync_sequencer_tail().await.is_ok() { | ||
| return Ok(*self.known_global_tail.get()); | ||
| } | ||
|
|
||
| // otherwise we need to try to fetch this from the log servers. | ||
| self.sync_log_servers_tail().await?; | ||
| Ok(*self.known_global_tail.get()) |
There was a problem hiding this comment.
Is there value in racing these two variants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ReplicatedLoglet] Implement remote sequencer find tail
Stack created with Sapling. Best reviewed with ReviewStack.