Add Java and Kotlin code snippets to all use case pages #437
Conversation
Deploying documentation with
|
| Latest commit: |
d546d42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://707c3c04.documentation-beg.pages.dev |
| Branch Preview URL: | https://kotlin-formatter.documentation-beg.pages.dev |
| @Handler | ||
| suspend fun run(ctx: Context, task: Task): Result { | ||
| val subTasks: Array<SubTask> = | ||
| ctx.runBlock (KtSerdes.json<Array<SubTask>>()) { |
There was a problem hiding this comment.
I think you should be able to remove the explicit type either here or on the val declaration
There was a problem hiding this comment.
Actually, you can simply remove the serde here, it's implicit
| split(task) | ||
| } | ||
|
|
||
| val resultFutures: MutableList<Awaitable<SubTaskResult>> = ArrayList() |
There was a problem hiding this comment.
| val resultFutures: MutableList<Awaitable<SubTaskResult>> = ArrayList() | |
| val resultFutures: MutableList<Awaitable<SubTaskResult>> = mutableListOf() |
| val result: String = rs | ||
| .invocationHandle( | ||
| handle.invocationId, | ||
| KtSerdes.json<String>() |
There was a problem hiding this comment.
Same comment about type inference as above
|
|
||
| suspend fun downloadData(userId: String, email: Email) { | ||
| // <mark_1> | ||
| val client: IngressClient = DataPreparationServiceClient.fromClient(rs, userId) |
There was a problem hiding this comment.
Maybe remove the type annotation IngressClient here?
| CompletableFuture.anyOf(client.workflowHandle().attachAsync()) | ||
| .orTimeout(30, TimeUnit.SECONDS) | ||
| .join() |
There was a problem hiding this comment.
Use kotlin stuff for this, not CompletableFuture
There was a problem hiding this comment.
All the client methods have a variant suspend, e.g. attachSuspend, which you import from dev.restate.sdk.kotlin. For timeouts: https://kotlinlang.org/docs/cancellation-and-timeouts.html#timeout
| ctx.sleep(5000.milliseconds) | ||
| // </mark_2> | ||
| // <mark_3> | ||
| userId = ctx.runBlock(KtSerdes.json<String>()) { |
There was a problem hiding this comment.
You don't need to provide serde, it's implicit
|
|
||
| // <mark_3> | ||
| val previousRole: UserRole = ctx.runBlock( | ||
| KtSerdes.json<UserRole>() |
| try { | ||
| // <mark_3> | ||
| val previous: Permission = ctx.runBlock ( | ||
| KtSerdes.json<Permission>() |
| ctx.runBlock { tryApplyUserRole(update.userId, update.role) } | ||
| // </mark_3> | ||
|
|
||
| val previousPermissions = ArrayList<Permission>() |
There was a problem hiding this comment.
| val previousPermissions = ArrayList<Permission>() | |
| val previousPermissions = mutableListOf<Permission>() |
| // <mark_1> | ||
| ProductServiceClient.fromClient(rs, productId) | ||
| .send() | ||
| .reserve(DEFAULT.withIdempotency(reservationId)); |
There was a problem hiding this comment.
Use qualified name, it helps understanding this without reading the import:
| .reserve(DEFAULT.withIdempotency(reservationId)); | |
| .reserve(CallRequestOptions.DEFAULT.withIdempotency(reservationId)); |
@slinkydeveloper reviewing the code snippets is enough. Especially Kotlin.