New sys_invocation_state and sys_journal tables #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think you also need to add these new fields restatedev/restate#913
Deploying with
|
| Latest commit: |
536c598
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a28ae8e4.documentation-beg.pages.dev |
| Branch Preview URL: | https://tables.documentation-beg.pages.dev |
tillrohrmann
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Thanks for creating this PR @jackkleeman. There seem to be a few fields missing that were added lately.
| | `in_flight` | `Boolean` | Indicates whether there is currently an execution running for this invocation. | | | ||
| | `retry_count` | `UInt64` | The number of attempts for this particular execution of this invocation. Increments on start, so 2 or more means a failure occurred. | | | ||
| | `last_start_at` | `Date64` | Timestamp indicating the start of the most recent execution of this invocation. | | | ||
| | `last_failure` | `Utf8` | An error message describing the most recent failure to execute this invocation, if any. | | |
There was a problem hiding this comment.
We seem to be missing the fields last_attempt_endpoint_id and next_retry_at.
There was a problem hiding this comment.
can you refresh? i added these already
| | `id` | `Utf8` | [Invocation ID](/services/invocation#invocation-identifier), an opaque token that can be used to cancel an invocation of a service with the [admin API](/references/admin-api). | | | ||
| | `invoked_by` | `Utf8` | Enum describing the invoker of this service: `ingress` = invoked externally / `service` = invoked by a service. | | | ||
| | `invoked_by_service` | `Utf8` | The name of the invoking service. Or `null` if invoked via the ingress. | `com.example.Greeter` | | ||
| | `invoked_by_id` | `Utf8` | The Invocation ID of the service that triggered this invocation. Or `null` if invoked externally. | | |
There was a problem hiding this comment.
pinned_endpoint_id seems to be missing.
There was a problem hiding this comment.
can you refresh? i added this already
tillrohrmann
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add service_key_json cols
Best to review without whitespace, as i formatted the existing reference tables