Add kotlin github action checks, and make Kotlin code snippets build (#…

…356)
restatedev · Apr 23, 2024 · c8207a0 · c8207a0
1 parent e5c4179
commit c8207a0
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
@@ -114,6 +114,18 @@ jobs:
           arguments: check
           build-root-directory: code_snippets/java
 
+      # Upgrade Kotlin code snippets if new version is provided
+      - name: Find and replace restateVersion in build.gradle.kts for Kotlin code snippets
+        if: github.event.inputs.sdkJavaVersion != ''
+        run: sed -i 's/val restateVersion = "[0-9A-Z.-]*"/val restateVersion = "${{ inputs.sdkJavaVersion }}"/' code_snippets/kotlin/build.gradle.kts
+
+      # Check Kotlin code snippets
+      - name: Test Kotlin code snippets
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: check
+          build-root-directory: code_snippets/kotlin
+
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@v5
         with:

diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml
@@ -52,4 +52,11 @@ jobs:
         uses: gradle/gradle-build-action@v2
         with:
           arguments: check
-          build-root-directory: code_snippets/java
+          build-root-directory: code_snippets/java
+
+      # Check Java code snippets
+      - name: Test Kotlin code snippets
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: check
+          build-root-directory: code_snippets/kotlin
diff --git a/code_snippets/kotlin/src/main/kotlin/develop/Greeter.kt b/code_snippets/kotlin/src/main/kotlin/develop/Greeter.kt
@@ -29,6 +29,5 @@ fun main() {
   RestateHttpEndpointBuilder
       .builder()
       .bind(Greeter())
-      // Start the Restate Endpoint HTTP Server
       .buildAndListen()
 }
diff --git a/code_snippets/kotlin/src/main/kotlin/develop/ServingVirtualThreads.kt b/code_snippets/kotlin/src/main/kotlin/develop/ServingVirtualThreads.kt
@@ -1,7 +1,7 @@
 package develop
 
 import dev.restate.sdk.http.vertx.RestateHttpEndpointBuilder
-import dev.restate.sdk.kotlin.Component
+import dev.restate.sdk.kotlin.Service
 import java.util.concurrent.Executors
 import kotlinx.coroutines.asCoroutineDispatcher
 
@@ -10,9 +10,9 @@ class ServingVirtualThreads {
         // <start_here>
         builder.bind(
             // This is the class generated by the annotation processor
-            GreeterBindableComponent(
+            GreeterBindableService(
                 Greeter(),
-                Component.Options(
+                Service.Options(
                     coroutineContext = Executors.newVirtualThreadPerTaskExecutor().asCoroutineDispatcher()
                 )
             )