Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Co-authored-by: Till Rohrmann <[email protected]>
  • Loading branch information
@slinkydeveloper @tillrohrmann
slinkydeveloper and tillrohrmann authored Dec 19, 2023
1 parent b35a27c commit a34da5d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/services/upgrades-removal.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ $ curl -X DELETE <RESTATE_META_ENDPOINT>/deployments/{DEPLOYMENT_ID}?force=true
```

:::info
Currently Restate doesn't implement all the checks to safely remove a deployment, so you have to force the removal through the `force` query parameter.
Currently Restate doesn't implement all the checks to safely remove a service deployment, so you have to force the removal through the `force` query parameter.

Check warning on line 116 in docs/services/upgrades-removal.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/services/upgrades-removal.md#L116 

[write-good.Weasel] 'Currently' is a weasel word!
Raw output 
{"message": "[write-good.Weasel] 'Currently' is a weasel word!", "location": {"path": "docs/services/upgrades-removal.md", "range": {"start": {"line": 116, "column": 1}}}, "severity": "WARNING"}

Check warning on line 116 in docs/services/upgrades-removal.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/services/upgrades-removal.md#L116 

[write-good.Weasel] 'safely' is a weasel word!
Raw output 
{"message": "[write-good.Weasel] 'safely' is a weasel word!", "location": {"path": "docs/services/upgrades-removal.md", "range": {"start": {"line": 116, "column": 55}}}, "severity": "WARNING"}
:::
4 changes: 2 additions & 2 deletions docs/tour.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ When you are finished with the tour, you can stop Restate with `docker stop rest

### Registering services with Restate

When Restate first comes up, it doesn't know anything about our services. Let's tell it where they are running. You can trigger service discovery by calling the Restate admin API informing it about the deployment endpoint where our service is listening.
When Restate first comes up, it doesn't know anything about our services. Let's tell it where they are running. You can trigger service discovery by calling the Restate admin API informing it about the service deployment where our service is listening.

Check warning on line 152 in docs/tour.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/tour.mdx#L152 

[Google.We] Try to avoid using first-person plural like 'our'.
Raw output 
{"message": "[Google.We] Try to avoid using first-person plural like 'our'.", "location": {"path": "docs/tour.mdx", "range": {"start": {"line": 152, "column": 61}}}, "severity": "WARNING"}

Check warning on line 152 in docs/tour.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/tour.mdx#L152 

[Google.We] Try to avoid using first-person plural like 'Let's'.
Raw output 
{"message": "[Google.We] Try to avoid using first-person plural like 'Let's'.", "location": {"path": "docs/tour.mdx", "range": {"start": {"line": 152, "column": 75}}}, "severity": "WARNING"}

Check notice on line 152 in docs/tour.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/tour.mdx#L152 

[Google.Contractions] Use 'they're' instead of 'they are'.
Raw output 
{"message": "[Google.Contractions] Use 'they're' instead of 'they are'.", "location": {"path": "docs/tour.mdx", "range": {"start": {"line": 152, "column": 95}}}, "severity": "INFO"}

Check notice on line 152 in docs/tour.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/tour.mdx#L152 

[write-good.E-Prime] Try to avoid using 'are'.
Raw output 
{"message": "[write-good.E-Prime] Try to avoid using 'are'.", "location": {"path": "docs/tour.mdx", "range": {"start": {"line": 152, "column": 100}}}, "severity": "INFO"}

Check warning on line 152 in docs/tour.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/tour.mdx#L152 

[Google.WordList] Use 'administrator' instead of 'admin'.
Raw output 
{"message": "[Google.WordList] Use 'administrator' instead of 'admin'.", "location": {"path": "docs/tour.mdx", "range": {"start": {"line": 152, "column": 170}}}, "severity": "WARNING"}

Check notice on line 152 in docs/tour.mdx

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/tour.mdx#L152 

[write-good.E-Prime] Try to avoid using 'is'.
Raw output 
{"message": "[write-good.E-Prime] Try to avoid using 'is'.", "location": {"path": "docs/tour.mdx", "range": {"start": {"line": 152, "column": 240}}}, "severity": "INFO"}

<Tabs groupId="operating-systems">
<TabItem value="lin" label="Linux">
Expand All @@ -162,7 +162,7 @@ curl -X POST http://localhost:9070/deployments -H 'content-type: application/jso
<TabItem value="mac" label="macOS">

You do this by sending a request to the Restate endpoint at `http://localhost:9070/deployments`
and providing it with the deployment endpoint of the service `http://host.docker.internal:9080`.
and providing it with the service deployment URL `http://host.docker.internal:9080`.

```shell
curl -X POST http://localhost:9070/deployments -H 'content-type: application/json' -d '{"uri": "http://host.docker.internal:9080"}'
Expand Down

0 comments on commit a34da5d

Please sign in to comment.