Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some new devices added to devicelist.ts #1293

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Some new devices added to devicelist.ts #1293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
830bd26
Some new devices added to devicelist.ts
Sep 5, 2024
6600efe
fixed id and added prettier
Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions desktop-app/src/common/deviceList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,19 @@ export const defaultDevices: Device[] = [
isTouchCapable: true,
isMobileCapable: true,
},
{
id: '20016',
name: 'Pixel 7',
width: 412,
height: 915,
dpr: 2.625,
capabilities: ['touch', 'mobile'],
userAgent:
'Mozilla/5.0 (Linux; Android 13; Pixel 7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.120 Mobile Safari/537.36',
type: 'phone',
isTouchCapable: true,
isMobileCapable: true,
},
{
id: '30001',
name: 'Samsung Galaxy S8+',
Expand Down Expand Up @@ -675,6 +688,19 @@ export const defaultDevices: Device[] = [
isTouchCapable: true,
isMobileCapable: true,
},
{
id: '30018',
name: 'Galaxy Z Fold 5',
width: 344,
height: 882,
dpr: 1,
capabilities: ['touch', 'mobile'],
userAgent:
'Mozilla/5.0 (Linux; Android 13; SM-F946B) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.5735.131 Mobile Safari/537.36',
type: 'phone',
isTouchCapable: true,
isMobileCapable: true,
},
{
id: '40001',
name: 'Nokia Lumia 520',
Expand Down Expand Up @@ -870,6 +896,19 @@ export const defaultDevices: Device[] = [
isTouchCapable: false,
isMobileCapable: false,
},
{
id: '90004',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the IDs to stick to the guidelines here: https://github.com/responsively-org/responsively-app/pull/1293/files#diff-1f757e572fe35320119d79efc7411be133df8ec132a1737e78a872eaa1720da8R16-R22

name: 'Asus Zenbook Fold',
width: 853,
height: 1280,
dpr: 2,
capabilities: ['touch', 'tablet'],
userAgent:
'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.85 Safari/537.36',
type: 'tablet',
isTouchCapable: true,
isMobileCapable: false,
},
];

const customDevices: () => Device[] = () => {
Expand Down
Loading