Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tidy-ups #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Small tidy-ups #16

wants to merge 3 commits into from

Conversation

Jaffa
Copy link
Contributor

@Jaffa Jaffa commented Dec 28, 2017

While getting familiar with the code, I found a number of small issues:

  1. The frame size is set in avs/main.py for using hotwords, and in avs/check.py, but not in avs/alexa.py.
  2. The examples for setting up valid callback URLs - for example https://github.com/alexa/alexa-avs-sample-app/wiki/Create-Security-Profile use localhost, not 127.0.0.1
  3. There's a hardcoded ReSpeaker client ID & secret, which means if the user doesn't pass in config.json, they'll end up authorising your account by accident.

@xiongyihui
Copy link
Contributor

The hardcoded ReSpeaker client ID is a feature for these who just want to try Alexa as quick as possible.

@Jaffa
Copy link
Contributor Author

Jaffa commented Dec 31, 2017

The hardcoded ReSpeaker client ID is a feature for these who just want to try Alexa as quick as possible.

OK, makes sense. Could I suggest one of the following:

  1. A warning and/or explicit approval? Perhaps with an input
  2. Move it into an example config.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants