Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate taxes after mapping #2670

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Oct 18, 2024

Screenshot 2024-10-18 at 12 07 35 PM

When enabling the Auto Create Purchase Receipt, the GST is not being automatically calculated, requiring manual entry of the purchase taxes and charges.

Huly®: IC-2794

@Ninad1306 Ninad1306 assigned Ninad1306 and vorasmit and unassigned Ninad1306 Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.31%. Comparing base (4bb9af2) to head (f5bed26).

Files with missing lines Patch % Lines
...compliance/gst_india/overrides/purchase_receipt.py 38.46% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2670      +/-   ##
===========================================
- Coverage    61.33%   61.31%   -0.03%     
===========================================
  Files          119      119              
  Lines        11505    11518      +13     
===========================================
+ Hits          7057     7062       +5     
- Misses        4448     4456       +8     
Files with missing lines Coverage Δ
india_compliance/hooks.py 100.00% <ø> (ø)
...compliance/gst_india/overrides/purchase_receipt.py 64.28% <38.46%> (-22.39%) ⬇️

Impacted file tree graph

@vorasmit
Copy link
Member

This fix may be needed in ERPNext.

@vorasmit vorasmit closed this Oct 18, 2024
@Ninad1306 Ninad1306 deleted the add_taxes_for_purchase_receipt branch October 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants