fix: only show warning for subcontracting receipt #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorasmit
force-pushed
the
remove_validation
branch
from
5583fac
to
3f30d96
Compare
|
Can we add test cases for them? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2652 +/- ##
===========================================
+ Coverage 60.41% 61.34% +0.92%
===========================================
Files 119 119
Lines 11493 11506 +13
===========================================
+ Hits 6944 7058 +114
+ Misses 4549 4448 -101
... and 1 file with indirect coverage changes |
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
* fix: only show warning for subcontracting receipt * chore: better formatting * test: test case to validate doc references --------- (cherry picked from commit ad4e139) # Conflicts: # india_compliance/gst_india/overrides/test_subcontracting_transaction.py
mergify bot
added a commit
that referenced
this pull request
Oct 14, 2024
…tfix/pr-2652 fix: only show warning for subcontracting receipt (backport #2652)
india-compliance-bot
added a commit
that referenced
this pull request
Oct 23, 2024
## [15.13.5](v15.13.4...v15.13.5) (2024-10-23) ### Bug Fixes * add comment in gst return log for backdated transactions ([#2656](#2656)) ([49bf757](49bf757)) * apply css to specific fields ([4021e06](4021e06)) * changes for test case ([943b0c7](943b0c7)) * changing the sequence as per sales invoice ([c886931](c886931)) * connection for e-Invoice log in purchase invoice ([5c70350](5c70350)) * filter for invalid invoice number in document issue summary ([#2641](#2641)) ([62912b6](62912b6)), closes [#2608](#2608) * only show warning for subcontracting receipt ([#2652](#2652)) ([9536376](9536376)) * pos based on account settings ([#2647](#2647)) ([f6a4a9c](f6a4a9c)) * resolve merge conflict ([c457198](c457198)) * resolve merge conflict ([fb1cfac](fb1cfac)) * resolved conflicts ([10dcb49](10dcb49)) * update bill_from_address when required ([36180f5](36180f5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For subcontracting, users could have different workflows:
eg: Material sent to subcontractor directly from the supplier's warehouse.
Because of these reasons, it becomes difficult to add references.
With a warning, this document can be skipped in ITC-04.
Huly®: IC-2776