Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better permission check for viewing pending vouchers #2528

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

vorasmit
Copy link
Member

@vorasmit vorasmit commented Aug 20, 2024

https://discuss.frappe.io/t/gst-setting-write-access-for-gst-balance-report/131260

This ensures that someone with read permissions will still be able to update the docs with Company GSTIN with appropriate doc permissions.

This can finally be then executed by someone with write permissions for the doc.

Huly®: IC-2651

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.26%. Comparing base (48572d2) to head (bfc383c).
Report is 18 commits behind head on develop.

Files Patch % Lines
...liance/gst_india/report/gst_balance/gst_balance.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2528   +/-   ##
========================================
  Coverage    60.26%   60.26%           
========================================
  Files          119      119           
  Lines        11394    11394           
========================================
  Hits          6867     6867           
  Misses        4527     4527           
Files Coverage Δ
...liance/gst_india/report/gst_balance/gst_balance.py 0.00% <0.00%> (ø)

Impacted file tree graph

@vorasmit vorasmit merged commit 44633be into resilient-tech:develop Aug 22, 2024
13 checks passed
@vorasmit vorasmit deleted the fix-perm-check branch August 22, 2024 10:18
mergify bot added a commit that referenced this pull request Aug 22, 2024
…tfix/pr-2528

fix: better permission check for viewing pending vouchers (backport #2528)
mergify bot added a commit that referenced this pull request Aug 22, 2024
…tfix/pr-2528

fix: better permission check for viewing pending vouchers (backport #2528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant