Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Override Taxes based on Source and Destination #2506

Closed
wants to merge 1 commit into from

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Aug 8, 2024

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.09%. Comparing base (a0108de) to head (f31ca85).
Report is 40 commits behind head on develop.

Files Patch % Lines
...ia_compliance/gst_india/overrides/sales_invoice.py 22.22% 7 Missing ⚠️
...compliance/gst_india/overrides/purchase_invoice.py 28.57% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2506      +/-   ##
===========================================
- Coverage    61.15%   61.09%   -0.06%     
===========================================
  Files          118      118              
  Lines        11349    11364      +15     
===========================================
+ Hits          6940     6943       +3     
- Misses        4409     4421      +12     
Files Coverage Δ
india_compliance/hooks.py 100.00% <ø> (ø)
...compliance/gst_india/overrides/purchase_invoice.py 59.50% <28.57%> (-2.24%) ⬇️
...ia_compliance/gst_india/overrides/sales_invoice.py 77.93% <22.22%> (-3.69%) ⬇️

Impacted file tree graph

@Ninad1306 Ninad1306 requested a review from vorasmit August 9, 2024 11:56
@vorasmit vorasmit self-assigned this Aug 14, 2024
@vorasmit vorasmit marked this pull request as draft August 20, 2024 05:19
@vorasmit vorasmit removed their assignment Aug 20, 2024
@vorasmit
Copy link
Member

Closing in favour of : frappe/frappe#27488

@vorasmit vorasmit closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

override taxes based on place of supply in map doc
3 participants