Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect Company Filter in Purchase Reconciliation Tool #2505

Merged

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Aug 7, 2024

@Sanket322 Sanket322 changed the title fix: check company_name in purchase invoice and boe fix: check company in query of purchase reco tool Aug 7, 2024
@Sanket322 Sanket322 changed the title fix: check company in query of purchase reco tool fix: Respect Company Filter in Purchase Reconciliation Tool Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.91%. Comparing base (a0108de) to head (052fa92).
Report is 35 commits behind head on develop.

Files Patch % Lines
...a/doctype/purchase_reconciliation_tool/__init__.py 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2505      +/-   ##
===========================================
- Coverage    61.15%   59.91%   -1.24%     
===========================================
  Files          118      120       +2     
  Lines        11349    11469     +120     
===========================================
- Hits          6940     6872      -68     
- Misses        4409     4597     +188     
Files Coverage Δ
...a/doctype/purchase_reconciliation_tool/__init__.py 82.95% <77.77%> (-0.76%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

vorasmit
vorasmit previously approved these changes Aug 22, 2024
vorasmit
vorasmit previously approved these changes Aug 22, 2024
@vorasmit vorasmit merged commit dc91d22 into resilient-tech:develop Aug 22, 2024
11 checks passed
mergify bot added a commit that referenced this pull request Aug 22, 2024
…tfix/pr-2505

fix: Respect Company Filter in Purchase Reconciliation Tool (backport #2505)
mergify bot added a commit that referenced this pull request Aug 22, 2024
…tfix/pr-2505

fix: Respect Company Filter in Purchase Reconciliation Tool (backport #2505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect Company Filter in Purchase Reconciliation Tool
2 participants