Skip to content

Commit

Permalink
fix: update tds details in tax withholding category (#1688)
Browse files Browse the repository at this point in the history
* fix: update tds details in tax withholding category

* fix: linters

* fix: formatting

* fix: update tds_details

* fix: update fields and rates in tax withholding category

* fix: changes as per review

* fix: if condition

* refactor: variable names, update tax category algo, etc

* fix: run patch in post_install

* chore: resolve conflicts

---------

Co-authored-by: ljain112 <[email protected]>
  • Loading branch information
priyanshshah2442 and ljain112 authored Feb 27, 2024
1 parent 5d8ed51 commit cea0a67
Show file tree
Hide file tree
Showing 9 changed files with 1,494 additions and 114 deletions.
1 change: 1 addition & 0 deletions india_compliance/hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@
"validate": "india_compliance.gst_india.overrides.tax_category.validate"
},
"Tax Withholding Category": {
"validate": "india_compliance.income_tax_india.overrides.tax_withholding_category.validate",
"on_change": "india_compliance.income_tax_india.overrides.tax_withholding_category.on_change",
},
"Unreconcile Payment": {
Expand Down
27 changes: 27 additions & 0 deletions india_compliance/income_tax_india/constants/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
TDS_SECTIONS = [
"193",
"194",
"194BB",
"194EE",
"194A",
"194B",
"194C",
"194D",
"194F",
"194G",
"194H",
"194I",
"194JA",
"194JB",
"194LA",
"194I(a)",
"194I(b)",
"194LBA",
"194DA",
"192A",
"194LBB",
"194IA",
"194N",
]

TDS_ENTITY_TYPE = ["Individual", "Company", "Company Assessee", "No PAN / Invalid PAN"]
25 changes: 25 additions & 0 deletions india_compliance/income_tax_india/constants/custom_fields.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
from india_compliance.income_tax_india.constants import TDS_ENTITY_TYPE, TDS_SECTIONS

tds_section_options = "\n" + "\n".join(sorted(TDS_SECTIONS))
tds_entity_type_options = "\n" + "\n".join(sorted(TDS_ENTITY_TYPE))

party_fields = [
{
"fieldname": "pan",
Expand Down Expand Up @@ -25,4 +30,24 @@
),
}
],
"Tax Withholding Category": [
{
"label": "Section",
"fieldname": "tds_section",
"insert_after": "round_off_tax_amount",
"fieldtype": "Autocomplete",
"options": tds_section_options,
"translatable": 0,
"mandatory_depends_on": "eval:doc.entity_type",
},
{
"label": "Entity",
"fieldname": "entity_type",
"insert_after": "tax_on_excess_amount",
"fieldtype": "Select",
"options": tds_entity_type_options,
"translatable": 0,
"mandatory_depends_on": "eval:doc.tds_section",
},
],
}
Loading

0 comments on commit cea0a67

Please sign in to comment.