Update mattjurenka/morpho to 3.0.0 #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankjr
force-pushed
the
mattjurenka/morpho
branch
6 times, most recently
from
538da4e
to
b83cec2
Compare
|
Hmm, so I think (i) the wrapper ERC20 is unnecessary; and (ii) it would actually break rewards. Rewards have to be done from off-chain, which is fine, but in this case they would just accumulate to the wrapper ERC20 instead of the BackingManager/RevenueTrader. We can get rid of the wrapper ERC20 by moving the The tasks are useful but we need deployment scripts too. The deployment scripts can use the task to do the deployment but the relevant thing is to commit to some set of constructor args, probably the same as the test suite but not necessarily. There's an example at |
tbrent
reviewed
Jun 27, 2023
contracts/plugins/assets/morpho-aave/MorphoAAVEPositionWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/morpho-aave/MorphoAAVESelfReferentialCollateral.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/morpho-aave/MorphoAAVENonFiatCollateral.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/morpho-aave/MorphoAaveV2TokenisedDeposit.sol
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/morpho-aave/MorphoNonFiatCollateral.sol
Outdated
Show resolved
Hide resolved
scripts/deployment/phase2-assets/collaterals/deploy_morpho_aavev2_plugin.ts
Outdated
Show resolved
Hide resolved
test/plugins/individual-collateral/morpho-aave/MorphoAAVEFiatCollateral.test.ts
Show resolved
Hide resolved
test/plugins/individual-collateral/morpho-aave/MorphoAAVENonFiatCollateral.test.ts
Outdated
Show resolved
Hide resolved
contracts/plugins/assets/morpho-aave/MorphoNonFiatCollateral.sol
Outdated
Show resolved
Hide resolved
pmckelvy1
requested changes
Jun 27, 2023
contracts/plugins/assets/morpho-aave/MorphoAaveV2TokenisedDeposit.sol
Outdated
Show resolved
Hide resolved
jankjr
force-pushed
the
mattjurenka/morpho
branch
from
f75b190
to
4a97ead
Compare
tbrent
reviewed
Jun 28, 2023
tbrent
reviewed
Jun 28, 2023
tbrent
reviewed
Jun 28, 2023
test/plugins/individual-collateral/morpho-aave/MorphoAAVENonFiatCollateral.test.ts
Outdated
Show resolved
Hide resolved
jankjr
force-pushed
the
mattjurenka/morpho
branch
2 times, most recently
from
44f2b9b
to
2450e68
Compare
tbrent
reviewed
Jun 29, 2023
tbrent
reviewed
Jun 29, 2023
contracts/plugins/assets/morpho-aave/MorphoSelfReferentialCollateral.sol
Outdated
Show resolved
Hide resolved
tbrent
reviewed
Jun 29, 2023
jankjr
force-pushed
the
mattjurenka/morpho
branch
2 times, most recently
from
502d8a7
to
526af73
Compare
|
@pmckelvy1 Jan's most recent update to |
pmckelvy1
requested changes
Jun 30, 2023
jankjr
force-pushed
the
mattjurenka/morpho
branch
from
c61746c
to
bb0ae58
Compare
jankjr
force-pushed
the
mattjurenka/morpho
branch
2 times, most recently
from
6a1eaca
to
84205c9
Compare
jankjr
force-pushed
the
mattjurenka/morpho
branch
from
1c6fdc4
to
998006b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.