RToken Oracle #849
Merged
RToken Oracle #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatmittal
force-pushed
the
rtoken-oracle
branch
from
15a0727
to
3ae0eab
Compare
|
Sample RToken Oracle Result |
akshatmittal
force-pushed
the
rtoken-oracle
branch
from
7976e8c
to
fee0cb1
Compare
tbrent
reviewed
Jun 23, 2023
| /// @param a First to multiply | ||
| /// @param b Second to multiply | ||
| /// @param c Denominator | ||
| function safeMulDiv( |
There was a problem hiding this comment.
other reviewers, this is the function that needs your eyes
There was a problem hiding this comment.
As far as I can see safeMulDivonly diviates from mulDiv in the overflow case if (hi >= c) return FIX_MAX; - as is the intention.
I don't see any unintended behaviour introduced. LGTM
| return; | ||
| } | ||
|
|
||
| (uint192 low, uint192 high) = price(); |
There was a problem hiding this comment.
Noting out loud that when we bring the lotPrice changes over to this repo this should stay price() and should not change to lotPrice().
jankjr
approved these changes
Jun 27, 2023
pmckelvy1
requested changes
Jun 27, 2023
| uint256 result_256; | ||
| unchecked { | ||
| (uint256 hi, uint256 lo) = fullMul(a, b); | ||
| if (hi >= c) return FIX_MAX; |
There was a problem hiding this comment.
this line and L595 are the only 2 that feel a bit odd to me, but we already follow a similar pattern in safeMul, so i think this is correct to return FIX_MAX instead of erroring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle implementation for RTokens based on internal pricing logic.