3.0.0 #809

tbrent · 2023-05-05T16:31:44Z

No description provided.

StRSR: require basket ready

…otocol into itrade-dutch-auction

* implement DutchTrade * add hardhat-storage-layout plugin * first compile * tuning * prevent bidding in same block as auction creation * chain bid into new auction * add 1-block cooldown between trades of the same type * more tuning * rate-limit same-kind auctions based on endTime(), not time of settlement * switch order of TradeKind and TradeRequest * RevenueTrader * lint clean * RevenueTrader: expose distributeTokenToBuy directly * refresh()/melt() before RevenueTrader manageToken * update scripts * fix gap * DutchTrade asserts * Broker events/governance setters * Trading minor ternary expression optimization * RevenueTrader require bugfix * RevenueTrader: minimize melting + asset refresh() * keep RToken up to backingBuffer as well * do not manageToken() after handoutRevenue(); leave for facade * p0 + p1 tests * docs/system-design.md * scenario tests * integration tests * reorder FacadeAct tests * plugin integration tests * make backingBuffer handling more straightforward * tests back to passing * fix typo * move tradeEnd into BackingManager + bugfixes * initial revenue dutch tests * sync BackingManagerP0/P1 * lint clean * better error message + fix EasyAuction test * BackingManager tests * fix tests * guard against reentrancy + eliminate 12s magic number throughout codebase * reorder FacadeAct tests * confirm DutchTrade has starting balance * wrap up DutchTrade testing * gas tests for Broker / BackingManager * 80% -> 85% * phase3-rtoken/rTokenConfig.ts * set backing buffer to 0 in recollat test * clarify seemingly obsolete test * pull out as much as possible into beforeEach from Broker GnosisTrade/DutchTrade tests * nits * empty buffer block * add full recollateralization tests * RevenueTraderP1.manageToken() reentrancy nitpick * comment RCEI * label checks/effects/interactions * lint clean * fix tests & linting. * add invalid claim logic replacement tests * missing revenue test * fix plugin tests --------- Co-authored-by: pmckelvy1 <[email protected]>

Co-authored-by: brr <[email protected]> Co-authored-by: Taylor Brent <[email protected]> Co-authored-by: pmckelvy1 <[email protected]>

Co-authored-by: Patrick McKelvy <[email protected]>

Co-authored-by: Akshat Mittal <[email protected]> Co-authored-by: brr <[email protected]> Co-authored-by: Taylor Brent <[email protected]> Co-authored-by: Julian M. Rodriguez <[email protected]>

Co-authored-by: brr <[email protected]> Co-authored-by: Taylor Brent <[email protected]> Co-authored-by: pmckelvy1 <[email protected]> Co-authored-by: Julian M. Rodriguez <[email protected]>

Co-authored-by: Patrick McKelvy <[email protected]>

tbrent · 2023-09-14T23:49:18Z

@julianmrodri can you confirm the .openzeppelin/mainnet-3_0_0.json file is correct and what we want?

julianmrodri · 2023-09-15T14:30:20Z

@julianmrodri can you confirm the .openzeppelin/mainnet-3_0_0.json file is correct and what we want?

The contents in that file match what it was deployed. However if you compile the code now, and pretend to reproduce the deployment the implementations of BackingManagerP1 and BasketHandlerP1, produce a different hash. I double checked this and see there are no differences in terms of variables, slots, types, but some internal "references" to contracts differ a bit (seems to be an internal id that OZ uses to connect compiled contracts)

This does not create issues to upgrade or release new versions. I ran a POC locally for both contracts and was able to upgrade the 3.0.0 implementation with no issues. There was probably something different in the compilation at the time it was deployed vs now. But this is not a big deal I think. I've opened a question with OZ to understand what could cause these differences.

I'll be opening a PR using Infura instead of Alchemy so we can group into a single network file.

tbrent · 2023-09-15T16:06:15Z

@julianmrodri can you confirm the .openzeppelin/mainnet-3_0_0.json file is correct and what we want?

The contents in that file match what it was deployed. However if you compile the code now, and pretend to reproduce the deployment the implementations of BackingManagerP1 and BasketHandlerP1, produce a different hash. I double checked this and see there are no differences in terms of variables, slots, types, but some internal "references" to contracts differ a bit (seems to be an internal id that OZ uses to connect compiled contracts)

This does not create issues to upgrade or release new versions. I ran a POC locally for both contracts and was able to upgrade the 3.0.0 implementation with no issues. There was probably something different in the compilation at the time it was deployed vs now. But this is not a big deal I think. I've opened a question with OZ to understand what could cause these differences.

I'll be opening a PR using Infura instead of Alchemy so we can group into a single network file.

Very nice, thanks.

tbrent · 2023-09-15T16:06:47Z

It's also expected for DeployerP1 to be different; I added an event to deployRTokenAsset() that isn't worth re-redeploying for.

julianmrodri · 2023-09-15T19:44:15Z

The difference I was seeing was due to using different external library addresses which are linked to BM and BH. So this is perfectly fine if I use the same addresses you used for this deployment.

tbrent and others added 30 commits May 3, 2023 18:41

Merge branch '3.0.0' into multiple-nonce-redemption

13115e0

StRSR: require basket ready

fe6bebd

second implementation pass

1913fc9

lint clean

57a2045

basket handler nits + add getHistoricalBasket() function

000ac1d

small contract size wins

60517ad

Merge branch '3.0.0' into itrade-dutch-auction

63257bd

Merge pull request #807 from reserve-protocol/withdraw-basket-ready

d91676b

StRSR: require basket ready

lint clean

5c4912b

fix tests & linting.

ca96dea

Merge branch 'itrade-dutch-auction' of github.com:reserve-protocol/pr…

e925f26

…otocol into itrade-dutch-auction

add invalid claim logic replacement tests

d5cd91a

missing revenue test

75c1094

try furnace.melt() again

7f7159d

cosmetics

e965298

Merge branch 'itrade-dutch-auction' into multiple-nonce-redemption

3821b3d

external Basket lib

396a357

add a way to manually start sell off tokens via the RevenueTrader

4d8cfbd

minor renaming

bb19dd0

tests

cb03de7

scripts

35002a0

add safe mulDiv to custom redemption in case of hyperinflated refPerTok

e73033c

try-catch to handle unregistered assets

89916aa

RToken + Main tests

0f27c08

add test for splitting portions and test portions sum to 1

7c5dafc

add simulation help by returning actual amounts transferred

5e5e9cc

BasketLib proofreading

870e86b

Merge branch '3.0.0' into facade-read-return-to-revenue

fe23118

update to 3.0.0 BackingManager/RevenueTrader behavior

689fc31

julianmrodri and others added 18 commits July 6, 2023 09:01

prettier fixes 3.0.0 (#859)

aedbd14

ci tests - non-determinism (#858)

ce892b2

fix storage slots Distributor (#865)

eea6776

additional furnace timestamp check (#866)

e351b32

Base Testnet configuration (#867)

6da3481

Base Testnet configuration (#867)

a1092d7

Stargate Asset Plugin (#863)

05961a1

Co-authored-by: brr <[email protected]> Co-authored-by: Taylor Brent <[email protected]> Co-authored-by: pmckelvy1 <[email protected]>

Update mattjurenka/morpho to 3.0.0 (#853)

9ee60f1

Co-authored-by: Patrick McKelvy <[email protected]>

3.0.0 rc5 (#882)

a0480a8

Co-authored-by: Akshat Mittal <[email protected]> Co-authored-by: brr <[email protected]> Co-authored-by: Taylor Brent <[email protected]> Co-authored-by: Julian M. Rodriguez <[email protected]>

Merge branch 'master' into 3.0.0

7b3d401

3.0.0 rc6 (#912)

c237cfb

Co-authored-by: brr <[email protected]> Co-authored-by: Taylor Brent <[email protected]> Co-authored-by: pmckelvy1 <[email protected]> Co-authored-by: Julian M. Rodriguez <[email protected]>

update base goerli addresses (#937)

baa7f5b

script to grab rtoken & implementation addys for dev docs (#932)

fe502d2

Upg checker - update addresses 3.0.0 deployment (#943)

e259d78

Improve proposal with final addresses (#945)

97071a3

fix RToken exhaustive tests (#946)

4e010df

3.0.0 deploy (#935)

9896102

Co-authored-by: Patrick McKelvy <[email protected]>

Updated gas snapshots (#942)

27c580b

Co-authored-by: Patrick McKelvy <[email protected]>

fix revenue appreciation extreme tests.

e12d643

julianmrodri and others added 4 commits September 18, 2023 07:20

use infura in deployment scripts (#948)

6c841f0

deployment-variables.md: fix rewardRatio default value

2ec019c

upg checker final tweaks (#949)

111c597

remove timeout

21b5234

tbrent merged commit 336e5b1 into master Sep 20, 2023
8 checks passed

tbrent deleted the 3.0.0 branch September 20, 2023 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3.0.0 #809

3.0.0 #809

tbrent commented May 5, 2023 •

edited

Loading

tbrent commented Sep 14, 2023 •

edited

Loading

julianmrodri commented Sep 15, 2023 •

edited

Loading

tbrent commented Sep 15, 2023

tbrent commented Sep 15, 2023

julianmrodri commented Sep 15, 2023

3.0.0 #809

3.0.0 #809

Conversation

tbrent commented May 5, 2023 • edited Loading

tbrent commented Sep 14, 2023 • edited Loading

julianmrodri commented Sep 15, 2023 • edited Loading

tbrent commented Sep 15, 2023

tbrent commented Sep 15, 2023

julianmrodri commented Sep 15, 2023

tbrent commented May 5, 2023 •

edited

Loading

tbrent commented Sep 14, 2023 •

edited

Loading

julianmrodri commented Sep 15, 2023 •

edited

Loading