OETH L2 Base plugin #1223
Closed
OETH L2 Base plugin #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
commented
Oct 30, 2024
clement-ux
commented
- OETH plugin and tests for L2 Base.
tbrent
reviewed
Nov 6, 2024
|
|
||
| /// @return {ref/tok} Quantity of whole reference units per whole collateral tokens | ||
| /// {superOETHb/wsuperOETHb} | ||
| function underlyingRefPerTok() public view override returns (uint192) { |
There was a problem hiding this comment.
could delete this function entirely if you change the inheritance to ERC4626FiatCollateral
| { | ||
| // {tar/tok} | ||
| // {ETH/wsuperOETHb} | ||
| uint192 targetPerTok = _safeWrap(targetPerTokChainlinkFeed.price()) / 1e18; |
There was a problem hiding this comment.
nit: should probably move the paren outside the 1e18 to minimize overflow risk
|
|
||
| /// @param config.chainlinkFeed - ignored | ||
| /// @param config.oracleTimeout - ignored | ||
| /// @param config.oracleError {1} Should be the oracle error for UoA/tok |
There was a problem hiding this comment.
this should be the combined oracle error I think, since it is applied post-product
There was a problem hiding this comment.
Nice catch, indeed. I remove the comment then 👍
tbrent
reviewed
Nov 6, 2024
| wsuperOETHb_ETH: bn(86400), | ||
| ETH_USD: bn(1200), | ||
| } | ||
| export const BASE_ORACLE_ERROR = combinedError( |
There was a problem hiding this comment.
what are these 3 errors being added? I was only expecting 2 of them, one per oracle
tbrent
reviewed
Nov 6, 2024
|
|
||
| // {tar/ref} = {tar/tok} / {ref/tok} Get current market peg | ||
| // ETH/superOETHb = ETH/wsuperOETHb / superOETHb/wsuperOETHb | ||
| pegPrice = targetPerTok.div(underlyingRefPerTok()); |
There was a problem hiding this comment.
could do pegPrice = FIX_ONE if these are both operating on the same underlying information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.