Skip to content

tweak oracle factory to also support chainlink interface #4052

tweak oracle factory to also support chainlink interface

tweak oracle factory to also support chainlink interface #4052

Triggered via pull request October 29, 2024 00:46
Status Success
Total duration 54m 18s
Artifacts

tests.yml

on: pull_request
Deployment Scripts
9m 22s
Deployment Scripts
Lint Checks
17m 12s
Lint Checks
Plugin Unit Tests
10m 35s
Plugin Unit Tests
Plugin Integration Tests (Mainnet) - 1/3
54m 10s
Plugin Integration Tests (Mainnet) - 1/3
Plugin Integration Tests (Mainnet) - 2/3
23m 4s
Plugin Integration Tests (Mainnet) - 2/3
Plugin Integration Tests (Mainnet) - 3/3
34m 31s
Plugin Integration Tests (Mainnet) - 3/3
Plugin Integration Tests (Base)
10m 49s
Plugin Integration Tests (Base)
Plugin Integration Tests (Arbitrum)
17m 47s
Plugin Integration Tests (Arbitrum)
P0 tests
16m 41s
P0 tests
P1 Tests
16m 10s
P1 Tests
Scenario Tests
8m 36s
Scenario Tests
Extreme Tests
50m 23s
Extreme Tests
Integration Tests
7m 37s
Integration Tests
Monitor Tests (Mainnet)
3m 13s
Monitor Tests (Mainnet)
Registry Tests
2m 5s
Registry Tests
Fit to window
Zoom out
Zoom in

Annotations

25 warnings
Registry Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Monitor Tests (Mainnet)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Integration Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Scenario Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deployment Scripts
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Base)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
P1 Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
P0 tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint Checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint Checks: contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
Lint Checks: contracts/facade/Facade.sol#L30
Fallback function must be simple
Lint Checks: contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
Lint Checks: contracts/p0/Deployer.sol#L179
Code contains empty blocks
Lint Checks: contracts/p1/Broker.sol#L40
Variable name must be in mixedCase
Lint Checks: contracts/p1/Main.sol#L158
Avoid to use low level calls
Plugin Integration Tests (Arbitrum)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Mainnet) - 2/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Mainnet) - 3/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Extreme Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Mainnet) - 1/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/