C4 Mitigations - 2024-07 #3912
Triggered via pull request
September 10, 2024 19:15
tbrent
Status
Success
Total duration
58m 10s
Artifacts
–
tests.yml
on: pull_request
Deployment Scripts
9m 2s
Lint Checks
13m 16s
Plugin Unit Tests
9m 55s
Plugin Integration Tests (Mainnet) - 1/3
57m 40s
Plugin Integration Tests (Mainnet) - 2/3
24m 56s
Plugin Integration Tests (Mainnet) - 3/3
33m 21s
Plugin Integration Tests (Base)
11m 10s
Plugin Integration Tests (Arbitrum)
17m 36s
P0 tests
18m 12s
P1 Tests
17m 23s
Scenario Tests
9m 52s
Extreme Tests
47m 28s
Integration Tests
10m 28s
Monitor Tests (Mainnet)
3m 11s
Registry Tests
2m 9s
Annotations
25 warnings
|
Registry Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Monitor Tests (Mainnet)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Deployment Scripts
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Scenario Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Integration Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Base)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
|
Lint Checks:
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
|
|
Lint Checks:
contracts/p0/Deployer.sol#L179
Code contains empty blocks
|
|
Lint Checks:
contracts/p1/Broker.sol#L40
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/p1/Main.sol#L158
Avoid to use low level calls
|
|
P1 Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Arbitrum)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
P0 tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Mainnet) - 2/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Mainnet) - 3/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Extreme Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Mainnet) - 1/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|