C4 Mitigations - 2024-07 #3899
Triggered via pull request
September 10, 2024 13:44
akshatmittal
Status
Cancelled
Total duration
5m 12s
Artifacts
–
tests.yml
on: pull_request
Deployment Scripts
4m 41s
Lint Checks
4m 39s
Plugin Unit Tests
4m 39s
Plugin Integration Tests (Mainnet) - 1/3
4m 40s
Plugin Integration Tests (Mainnet) - 2/3
4m 40s
Plugin Integration Tests (Mainnet) - 3/3
4m 44s
Plugin Integration Tests (Base)
4m 38s
Plugin Integration Tests (Arbitrum)
4m 37s
P0 tests
4m 38s
P1 Tests
4m 39s
Scenario Tests
4m 39s
Extreme Tests
4m 39s
Integration Tests
4m 40s
Monitor Tests (Mainnet)
3m 23s
Registry Tests
2m 43s
Annotations
26 errors and 12 warnings
|
Plugin Integration Tests (Mainnet) - 2/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 2/3
The operation was canceled.
|
|
Extreme Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Extreme Tests
The operation was canceled.
|
|
Plugin Unit Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Unit Tests
The operation was canceled.
|
|
Plugin Integration Tests (Arbitrum)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Arbitrum)
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 1/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 1/3
The operation was canceled.
|
|
Scenario Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Scenario Tests
The operation was canceled.
|
|
Plugin Integration Tests (Base)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Lint Checks
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Base)
The operation was canceled.
|
|
Lint Checks
The operation was canceled.
|
|
P0 tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
P0 tests
The operation was canceled.
|
|
Integration Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Integration Tests
The operation was canceled.
|
|
Deployment Scripts
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Deployment Scripts
The operation was canceled.
|
|
P1 Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
P1 Tests
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 3/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 3/3
The operation was canceled.
|
|
Registry Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Monitor Tests (Mainnet)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
|
Lint Checks:
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
|
|
Lint Checks:
contracts/p0/Deployer.sol#L180
Code contains empty blocks
|
|
Lint Checks:
contracts/p1/Main.sol#L158
Avoid to use low level calls
|
|
Lint Checks:
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase
|