Skip to content

C4 Mitigations - 2024-07 #3897

C4 Mitigations - 2024-07

C4 Mitigations - 2024-07 #3897

Triggered via pull request September 10, 2024 13:42
Status Cancelled
Total duration 1m 7s
Artifacts

tests.yml

on: pull_request
Deployment Scripts
30s
Deployment Scripts
Lint Checks
39s
Lint Checks
Plugin Unit Tests
40s
Plugin Unit Tests
Plugin Integration Tests (Mainnet) - 1/3
26s
Plugin Integration Tests (Mainnet) - 1/3
Plugin Integration Tests (Mainnet) - 2/3
38s
Plugin Integration Tests (Mainnet) - 2/3
Plugin Integration Tests (Mainnet) - 3/3
26s
Plugin Integration Tests (Mainnet) - 3/3
Plugin Integration Tests (Base)
26s
Plugin Integration Tests (Base)
Plugin Integration Tests (Arbitrum)
38s
Plugin Integration Tests (Arbitrum)
P0 tests
24s
P0 tests
P1 Tests
36s
P1 Tests
Scenario Tests
36s
Scenario Tests
Extreme Tests
38s
Extreme Tests
Integration Tests
28s
Integration Tests
Monitor Tests (Mainnet)
36s
Monitor Tests (Mainnet)
Registry Tests
37s
Registry Tests
Fit to window
Zoom out
Zoom in

Annotations

30 errors and 10 warnings
Plugin Integration Tests (Mainnet) - 1/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Plugin Integration Tests (Mainnet) - 1/3
The operation was canceled.
P0 tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
P0 tests
The operation was canceled.
Plugin Integration Tests (Base)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Plugin Integration Tests (Base)
The operation was canceled.
Plugin Integration Tests (Mainnet) - 3/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Plugin Integration Tests (Mainnet) - 3/3
The operation was canceled.
Deployment Scripts
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Deployment Scripts
The operation was canceled.
Integration Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Integration Tests
The operation was canceled.
Plugin Integration Tests (Mainnet) - 2/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Plugin Integration Tests (Mainnet) - 2/3
The operation was canceled.
Monitor Tests (Mainnet)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Monitor Tests (Mainnet)
The operation was canceled.
Registry Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Registry Tests
The operation was canceled.
Plugin Integration Tests (Arbitrum)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Plugin Integration Tests (Arbitrum)
The operation was canceled.
Scenario Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Scenario Tests
The operation was canceled.
P1 Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
P1 Tests
The operation was canceled.
Lint Checks
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Lint Checks
The operation was canceled.
Extreme Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Extreme Tests
The operation was canceled.
Plugin Unit Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
Plugin Unit Tests
The operation was canceled.
Lint Checks: contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
Lint Checks: contracts/facade/Facade.sol#L30
Fallback function must be simple
Lint Checks: contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
Lint Checks: contracts/p0/Deployer.sol#L180
Code contains empty blocks
Lint Checks: contracts/p1/Main.sol#L158
Avoid to use low level calls
Lint Checks: contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase