C4 Mitigations - 2024-07 · reserve-protocol/protocol@f532a2a

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run yarn lint: contracts/facade/Facade.sol#L30

When fallback is not payable you will not be able to receive ether

Run yarn lint: contracts/facade/Facade.sol#L30

Fallback function must be simple

Run yarn lint: contracts/facade/Facade.sol#L35

Avoid to use inline assembly. It is acceptable only in rare cases

Run yarn lint: contracts/facade/facets/RevenueFacet.sol#L47

Variable name must be in mixedCase

Run yarn lint: contracts/facade/facets/RevenueFacet.sol#L112

Variable name must be in mixedCase

Run yarn lint: contracts/facade/facets/RevenueFacet.sol#L113

Avoid to use inline assembly. It is acceptable only in rare cases

Run yarn lint: contracts/p0/AssetRegistry.sol#L128

Code contains empty blocks

Run yarn lint: contracts/p0/Deployer.sol#L180

Code contains empty blocks

Run yarn lint: contracts/p1/Main.sol#L158

Avoid to use low level calls

Run yarn lint: contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9

Variable name must be in mixedCase

Provide feedback