Added event-analyzer #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5hubh49
changed the title
xavpaice
reviewed
Aug 1, 2024
in-cluster/default.yaml
Outdated
| message: Event {{ .Reason }} by object {{ .InvolvedObject.Name }} kind {{ .InvolvedObject.Kind }} has message {{ .Message }} | ||
| - pass: | ||
| when: "false" | ||
| message: No OOMKilled event detected |
There was a problem hiding this comment.
maybe we should change the wording here to match the event
banjoh
reviewed
Aug 1, 2024
| outcomes: | ||
| - fail: | ||
| when: "true" | ||
| message: Event {{ .Reason }} by object {{ .InvolvedObject.Name }} kind {{ .InvolvedObject.Kind }} has message {{ .Message }} |
There was a problem hiding this comment.
nit: Perhaps we can have a message like below
Pod '{{ .InvolvedObject.Name }}' got killed (OOMKilling) with the reason: {{ .Message }}
There was a problem hiding this comment.
given that this event is kind: Node, is the object name not the node name? I guess we need an example event to confirm.
There was a problem hiding this comment.
@5hubh49 perhaps a good follow-up would be detecting which pod. Something like below. I tried to get a pod being OOMKilled, and emit an event, but couldn't
- event:
checkName: OOMkilled detector
namespace: default
reason: "OOMKilled"
kind: Pod
outcomes:
- fail:
when: "true"
message: Pod '{{ .InvolvedObject.Name }}' got killed with reason: {{ .Message }}
- pass:
when: "false"
message: No OOM killed pods found
adamancini
approved these changes
Aug 2, 2024
banjoh
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how analysis would look like: