implement Wait() on Strategy to fetch remaining errors #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we use an errgroup as a semaphore in buffer and consistent hash modes, but we never inspect the results of sem.Wait() to see if there were any errors. This results in errors being swallowed. This implements Wait(), and uses it everywhere we call Fetch(). Now that we have it, we don't need to store errors on bufferedReader so we can get rid of that.
philandstuff
force-pushed
the
wait-for-errors
branch
from
fce7106
to
e21925c
Compare
tempusfrangit
approved these changes
Mar 7, 2024
tempusfrangit
added a commit
that referenced
this pull request
Mar 15, 2024
This reverts commit c72c384. We cannot add more to the underlying waitgroup in eg after we call .Wait(). We're calling .Wait() as part of DownloadFile which could in some cases result in after .Wait() before return additional additions to the waitgroup. This is surfaced in multifile mode when the multifile number of buffers is below a critical threshold allowing for the downloader to begin a second file before the first file completed. Closes: #188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use an errgroup as a semaphore in buffer and consistent hash modes, but we never inspect the results of sem.Wait() to see if there were any errors. This results in errors being swallowed.
This implements Wait(), and uses it everywhere we call Fetch(). Now that we have it, we don't need to store errors on bufferedReader so we can get rid of that.