Update manifest.go

Address PR comments: * Do not return bool, err on isValidURL * Do not wrap error for the sake of wrapping the error. Co-authored-by: Philip Potter <[email protected]>
replicate · Feb 21, 2024 · b95096b · b95096b
1 parent 74d8b80
commit b95096b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/cmd/multifile/manifest.go b/cmd/multifile/manifest.go
@@ -104,8 +104,8 @@ func parseManifest(file io.Reader) (pget.Manifest, error) {
 				return nil, err
 			}
 		}
-		if valid, err := validURL(urlString); !valid {
-			return nil, fmt.Errorf("error parsing manifest invalid URL: %s: %w", urlString, err)
+		if err := validURL(urlString); err != nil {
+			return nil, err
 
 		}
 		manifest = manifest.AddEntry(urlString, dest)
@@ -114,7 +114,7 @@ func parseManifest(file io.Reader) (pget.Manifest, error) {
 	return manifest, nil
 }
 
-func validURL(s string) (bool, error) {
+func validURL(s string) error {
 	_, err := netUrl.Parse(s)
-	return err == nil, err
+	return err
 }