chore: Safe boilerplate & simple account automated tests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
feat/safe
branch
from
11c3a86
to
62fddb6
Compare
chris13524
force-pushed
the
feat/safe
branch
from
62fddb6
to
7330acb
Compare
chore: move `mod.rs` to `safe.rs`, fix warning
jackpooleywc
approved these changes
Sep 4, 2024
| @@ -0,0 +1,115 @@ | |||
| use alloy::{ | |||
There was a problem hiding this comment.
I've moved this to safe.rs rather than mod.rs as I find it easier find things and navigate Rust codebases
There was a problem hiding this comment.
I actually don't like the module organization you are using. I find files by navigating in the file tree, not by searching for them. This current module structure has related files spread out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--accounts 100flag as this resulted in long startup time