Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add horsepower to build process #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

arein
Copy link

@arein arein commented Sep 3, 2024

No description provided.

Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? I'm not sure we do since the tests pass in minutes already. This will cost us money to run these runners

Copy link
Contributor

@jackpooleywc jackpooleywc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the limiting factor here is our Swift CI pipeline. The Rust CI pipeline currently takes ~ 5mins, and the Swift CI takes ~ 10mins. They currently run in parallel so we usually wait ~ 10mins for CI to pass. Not sure what the extra cost is here, so I can't weigh in on if this is worth it. My suggestion would be to optimise the Swift pipeline as Rust is currently being built twice, if we can avoid that we might be able to get CI to pass in ~ 5mins or so. I believe the Swift pipeline is also more expensive as it has to run on macOS runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants