feat(op receipt): implement wait_for_user_operation_receipt #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpooleywc
force-pushed
the
jack/wait-for-user-operation-receipt
branch
2 times, most recently
from
d1238a3
to
46b2a9a
Compare
jackpooleywc
commented
Sep 15, 2024
| @@ -27,7 +27,8 @@ final class AccountClientTests: XCTestCase { | |||
| entryPoint: Self.entryPoint, | |||
| chainId: Self.chainId, | |||
| config: config, | |||
| signerType: .privateKey | |||
| signerType: .privateKey, | |||
| safe: false | |||
There was a problem hiding this comment.
Fix Swift tests broken in: https://github.com/WalletConnect/yttrium/pull/21
chris13524
reviewed
Sep 15, 2024
Done: https://github.com/WalletConnect/yttrium/pull/23/commits/8dec5f788a075f6795d289a0bf2378a31df06e76 |
jackpooleywc
force-pushed
the
jack/wait-for-user-operation-receipt
branch
2 times, most recently
from
3e67695
to
8dec5f7
Compare
@jackpooleywc can you add it back to all the tests, including the Safe one? |
chris13524
approved these changes
Sep 16, 2024
jackpooleywc
force-pushed
the
jack/wait-for-user-operation-receipt
branch
from
8dec5f7
to
852e8e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.