Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 7702 safe #18

Merged
merged 6 commits into from
Sep 12, 2024
Merged

feat: 7702 safe #18

merged 6 commits into from
Sep 12, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Sep 11, 2024 •
edited
Loading

WIP: attempting to use 7702 with a Safe

Possibly depends on: https://github.com/WalletConnect/alto/pull/1/files

@chris13524 chris13524 self-assigned this Sep 11, 2024
@chris13524 chris13524 marked this pull request as ready for review September 11, 2024 19:19
@jackpooleywc
Copy link
Contributor

jackpooleywc commented Sep 12, 2024 •
edited
Loading

Possibly depends on: https://github.com/WalletConnect/alto/pull/1/files

We don't want to upstream this I assume so maybe we should keep this in a branch rather than merging?

jackpooleywc
jackpooleywc reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@jackpooleywc jackpooleywc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to move the mock-aa-environment fork changes to the test/scripts/7702/docker-compose.yaml

test/scripts/forked_state/docker-compose.yaml Show resolved Hide resolved
crates/yttrium/src/bundler/client.rs Show resolved Hide resolved
@chris13524
Copy link
Member Author

Possibly depends on: https://github.com/WalletConnect/alto/pull/1/files

We don't want to upstream this I assume so maybe we should keep this in a branch rather than merging?

I don't think dependency forks have any affect on merging this PR

@jackpooleywc
Copy link
Contributor

Possibly depends on: https://github.com/WalletConnect/alto/pull/1/files

We don't want to upstream this I assume so maybe we should keep this in a branch rather than merging?

I don't think dependency forks have any affect on merging this PR

No I meant we might not want to merge: WalletConnect/alto#1

@chris13524
Copy link
Member Author

No I meant we might not want to merge: https://github.com/WalletConnect/alto/pull/1No I meant we might not want to merge: WalletConnect/alto#1

Ah, yes. We can just leave in the branch

jackpooleywc
jackpooleywc previously approved these changes Sep 12, 2024
View reviewed changes
@chris13524
feat: test Safe on Sepolia & Pimlico (#20)
71bf6bc 
* feat: test Safe against Sepolia and Sepolia

* chore: comment

* chore: prefer assert

* chore: add missing deps

* chore: Safe Swift refactor (#21)
@chris13524 chris13524 merged commit dfe0f88 into main Sep 12, 2024
3 checks passed
@chris13524 chris13524 deleted the feat/7702-safe branch September 12, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpooleywc jackpooleywc jackpooleywc left review comments

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris13524 @jackpooleywc