Merge pull request #1406 from WalletConnect/reorder-propose-response-…

…and-settle-request Reorder propose response and settle request
reown-com · Aug 23, 2024 · c15347b · c15347b
2 parents b9246a5 + f4d4ba4
commit c15347b
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/Sources/WalletConnectSign/Engine/Common/ApproveEngine.swift b/Sources/WalletConnectSign/Engine/Common/ApproveEngine.swift
@@ -159,7 +159,19 @@ final class ApproveEngine {
 
         do {
             let session: WCSession = try await settleRequestTask
+            eventsClient.saveTraceEvent(SessionApproveExecutionTraceEvents.sessionSettleSuccess)
+            logger.debug("Session settle request has been successfully processed")
+
+            do {
+                _ = try await proposeResponseTask
+                eventsClient.saveTraceEvent(SessionApproveExecutionTraceEvents.responseApproveSent)
+            } catch {
+                eventsClient.saveTraceEvent(ApproveSessionTraceErrorEvents.sessionSettleFailure)
+                throw error
+            }
+
             sessionStore.setSession(session)
+
             Task {
                 removePairing(pairingTopic: pairingTopic)
             }