Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding license to workspaces #79

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: adding license to workspaces #79

merged 1 commit into from
Apr 26, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds a license to workspaces. The license type is the same as in the root package: Apache-2.0.
This should fix license check errors.

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524
Copy link
Member

The solution used currently is to ignore them like so. So Blockchain API needs to add the ignore for WalletConnectRust repo.

But this works too

@geekbrother geekbrother merged commit 1319404 into main Apr 26, 2024
7 checks passed
@geekbrother geekbrother deleted the fix/add_license branch April 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants