Check if a password already was prompted #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes infinite loop in case of an empty password.
The issue #299.
There is another PR #303 which fixes the issue. But it adds another infinite loop and it isn't consistent with the behavior when a user inputs wrong password.
In case of a wrong password pg_repack throws an error like:
and it doesn't go to another loop and doesn't ask for another password.
In case of an empty password with this PR pg_repack will throw an error like:
Raising an error on empty password is consistent with other tools like
psql
.