Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling system tables errors #327

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Commits on Nov 28, 2019

  1. allow build with PostgreSQL 12

    Conflict changes was:
    new argument for RenameRelationInternal (,,,is_index)
    heap_open/heap_closewas moved to access/table.h (well, this is macro now, but I did not change callers code)
    Melkij authored and alexeyklyukin committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    fed2faf View commit details
    Browse the repository at this point in the history
  2. PostgreSQL 12 has no more OIDS support for user tables. relhasoids wa…

    …s removed from pg_class, so create separate get_relhasoids C function
    Melkij authored and alexeyklyukin committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    32d32e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6732338 View commit details
    Browse the repository at this point in the history
  4. tablespace test varian with qualified table name and without "TABLESP…

    …ACE pg_default" sentence
    
    Due late april postgresql commit 87259588d0ab0b8e742e30596afa7ae25caadb18
    Melkij authored and alexeyklyukin committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    91fe63e View commit details
    Browse the repository at this point in the history
  5. support for PostgreSQL 12: documentation changes, adding PG 12 to tra…

    …vis testing grid
    
    Prepare to releasee 1.4.5
    Melkij authored and alexeyklyukin committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    9e68b06 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1cb05a1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c3e3a79 View commit details
    Browse the repository at this point in the history
  8. yet another try to make travis works

    Melkij authored and alexeyklyukin committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    d52c633 View commit details
    Browse the repository at this point in the history
  9. one missed sudo, yet another try

    Melkij authored and alexeyklyukin committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    58614f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Configuration menu
    Copy the full SHA
    ee5f24a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9aa8b69 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Take ACCESS EXCLUSIVE LOCK carefully (#8)

    Try to get the lock in loop with timeouts using `lock_exclusive()`.
    This allows to not stuck lock queue for readers if pg_repack
    cannot take the lock fast enough.
    za-arthur authored Aug 18, 2021
    Configuration menu
    Copy the full SHA
    7513317 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Raise ERROR message during repack_drop() (#9)

    It is better to raise ERROR message if lock_exclusive() failed during
    calling repack.repack_drop() otherwise a user might not notice that
    pg_repack didn't clean up leftovers.
    za-arthur authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    95dd7fc View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Merge upstream (#10)

    * simple_prompt signature was changed
    
    * Use SearchSysCacheCopy1 macro instead of SearchSysCacheCopy direct call as more future-proof
    
    Per syscache.h:
    > The use of the macros below rather than direct calls to the corresponding
    > functions is encouraged, as it insulates the caller from changes in the
    > maximum number of keys.
    
    Also this fixes segfault on pg14, but still not sure why exactly.
    
    * Get rid the custom array_accum aggregate in favor of postgresql's built-in array_agg and string_agg.
    
    In postgresql 14, the signature of array_append was changed, and our create aggregate throws the error "function array_append(anyarray, anyelement) does not exist". Postgresql's built-in string_agg was introduced in postgresql 9.0, array_agg was from 8.4 release. Both are too old and no longer supported by pg_repack. So, instead of fixing the repack.array_accum, I want to drop it.
    One notable behavior difference is handling empty sets: array_agg will produce NULL. So I put several coalesce to avoid altering the query results.
    
    * Check for the existence of the tables specified by --table or --parent-table
    
    PostgreSQL 14 will produce something like
     ERROR: pg_repack failed with error: ERROR:  relation "dummy_table" does not exist
     CONTEXT:  unnamed portal parameter $2 = '...'
    The second line looks weird and breaks tests. The second word "ERROR" also looks strange. So an explicit check for the existence of a table has been added.
    
    * Prepare release 1.4.7
    
    First sketch to see what buildfarm thinks. Also recheck PGVER=9.6 build
    
    * ubuntu xenial is EOL, try focal 20.04 LTS
    
    * third party apt-repositories removed from the Bionic build image. Next try
    https://docs.travis-ci.com/user/reference/bionic/#third-party-apt-repositories-removed
    
    * amd64 packages only, please
    
    * apt repository section was changed?
    
    * postgresql-14 beta1 should be already in repo, retry
    
    * try a workaround for pg9.5, 9.6
    Possible we decide to drop these versions, but just check
    
    * missing build dependency by postgresql-server-dev lz4
    
    * update docs broken links
    
    * Remove connection info from error log
    
    * remove unnecessary plus operator
    
    * fix typo in pgut.c
    
    * Fix typo
    
    Fix typo
    
    * Reassure the user that it's ok to drop the extension
    
    See reorg#281
    
    Co-authored-by: melkij <[email protected]>
    Co-authored-by: Valeriya Popova <[email protected]>
    Co-authored-by: Daniel Merken <[email protected]>
    Co-authored-by: lincuiping <[email protected]>
    Co-authored-by: sunhm89 <[email protected]>
    Co-authored-by: zhuqx-fnst <[email protected]>
    Co-authored-by: Daniele Varrazzo <[email protected]>
    8 people authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    0b2ecf7 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Configuration menu
    Copy the full SHA
    254ba8b View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Configuration menu
    Copy the full SHA
    e463b81 View commit details
    Browse the repository at this point in the history
  2. code alignment

    chanukya571 committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    2fb3261 View commit details
    Browse the repository at this point in the history