-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for lock statement timeout #183
base: master
Are you sure you want to change the base?
Conversation
Thanks, I think a configurable What if we just had the lock wait step be 10% of the |
I don't have strong opinions but I'd suggest keeping the step parameter as it's strictly more useful (arguably to a small group but it doesn't matter to the other). Defaulting wait-step to 10% of max-wait sounds nice a nice default though. |
I finally had the time to revisit this. Change updated as you suggested. |
Thanks for the pull request @arthurprs! This is exactly what I was looking for --- we have a highly contested server and was in need of having a variable timeout for the lock. @schmiddy would you mind merging this? |
We have a similar patch internally, and would greatly appreciate having it merged so that we can use the upstream package. |
@arthurprs Can you please rebase this PR? This will trigger the Checks. |
1862b28
to
903e079
Compare
This change was needed to get pg_repack to get the locks in our reasonably busy servers.