Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMake build system integration #133

Merged
merged 10 commits into from
Sep 30, 2024

Conversation

brainos233
Copy link
Contributor

@brainos233 brainos233 commented May 30, 2024

This PR enhances the cmake build system integration, specifically, it does the following things:

  • Set -fuse-ld=lld directly, this is llvm's recommend method to use lld in https://lld.llvm.org/#using-lld
  • Remove ccache from the build utils, since ccache is only effective for compiler
  • Split variable cmake into cmake_configure and cmake_args for clarity
  • Use ninja as default generator for cmake to speed up building process
  • Add CMAKE_BUILD_PARALLEL_LEVEL to control the maximum number of build processes
  • Call cmake to compile and install, which allows set generator without changing compile and install commands, and making CMAKE_BUILD_PARALLEL_LEVEL take effect automatically
  • Prefer to use cmake's own way of setting C/C++ standard and linker type if available, this prevents cmake projects from setting the default value for CMAKE_<LANG>_STANDARD and overwriting renpy's C/C++ std version

@renpytom renpytom merged commit b58b864 into renpy:master Sep 30, 2024
renpytom added a commit that referenced this pull request Oct 3, 2024
The problem was that the newer system lld doesn't like some symbols
in ancient libGLs used on Linux platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants