Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lockFileMaintenance): add pmd.lock #22364

Merged

Conversation

b-kamphorst
Copy link
Contributor

Changes

#22244 introduces support for pdm.lock lockfiles. This MR adds the change to the documentation.

Context

Relates to:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@b-kamphorst
Copy link
Contributor Author

Note: I expected to find the PEP621 manager in the 'python' section of https://docs.renovatebot.com/modules/manager/, but it is in other. Additionally, I'd be nice to list the 'PEP621 processors', currently just pdm, in the python overview as well -> this is where users will look first. Unfortunately, I don't understand the docs generation and am not sufficiently proficient with that / TypeScript to propose a change.

@b-kamphorst
Copy link
Contributor Author

Note: I expected to find the PEP621 manager in the 'python' section of https://docs.renovatebot.com/modules/manager/, but it is in other.

Can we just add export const language: ProgrammingLanguage = 'python'; to lib/modules/manager/pep621/index.ts, or does that have undesired effects in other places as well?

@rarkins rarkins enabled auto-merge May 23, 2023 05:47
@rarkins rarkins added this pull request to the merge queue May 23, 2023
Merged via the queue into renovatebot:main with commit a27cec8 May 23, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.98.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants