Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: better storage integrity handling #94

Open
Supremesource opened this issue May 10, 2024 · 2 comments
Open

refac: better storage integrity handling #94

Supremesource opened this issue May 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Supremesource
Copy link
Member

Supremesource commented May 10, 2024

In src/lib where we store majority of our blockchain's storages, we have all types separated, making code harder to manage. This can cause storage integrity problems. Values like min_burn and max_burn (and many others, follow the same logic) should be together in a struct. Such that the minimum can not be larger than the maximum.

@Supremesource
Copy link
Member Author

are we done here @devwckd ?

@devwckd
Copy link

devwckd commented May 17, 2024

I've moved the burn related params but there's still room for improvement that I'll be tackling asap.

Supremesource added a commit that referenced this issue Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants