Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac(pallets/subspace): group burn related values into BurnConfig #100

Merged
merged 4 commits into from
May 13, 2024

Conversation

devwckd
Copy link

@devwckd devwckd commented May 13, 2024

This PR:

  • Group all burn related storage values into the struct BurnConfiguration stored on BurnConfig.
  • Renames the storage value RemovedSubnets to SubnetGaps (side effect)

Part of #94

@@ -211,7 +230,8 @@ impl<T: Config> Pallet<T> {
FloorDelegationFee::<T>::put(delegation_fee)
}

// Proposals
//

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse comment aqui dawg

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matue-pelado

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PAISAO

@devwckd devwckd force-pushed the refac/storage-integrity branch 2 times, most recently from 7f895fd to 831ef18 Compare May 13, 2024 17:42
@@ -162,6 +190,9 @@ impl<T: Config> Pallet<T> {
Self::set_proposal_cost(params.proposal_cost);
Self::set_proposal_expiration(params.proposal_expiration);
Self::set_proposal_participation_threshold(params.proposal_participation_threshold);

// burn
let _ = params.burn_config.apply();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call expect here

@saiintbrisson saiintbrisson merged commit 78d3b18 into main May 13, 2024
1 check passed
Supremesource added a commit that referenced this pull request May 22, 2024
saiintbrisson added a commit that referenced this pull request Jun 2, 2024
…100)

* refac: move burn related params to BurnConfig

* fix: rename removed subnets storage value

* chore: make clippy happy

* chore: add changelog

---------

Co-authored-by: saiintbrisson <[email protected]>
saiintbrisson added a commit that referenced this pull request Jun 2, 2024
…100)

* refac: move burn related params to BurnConfig

* fix: rename removed subnets storage value

* chore: make clippy happy

* chore: add changelog

---------

Co-authored-by: saiintbrisson <[email protected]>
saiintbrisson added a commit that referenced this pull request Jun 5, 2024
…100)

* refac: move burn related params to BurnConfig

* fix: rename removed subnets storage value

* chore: make clippy happy

* chore: add changelog

---------

Co-authored-by: saiintbrisson <[email protected]>
@saiintbrisson saiintbrisson deleted the refac/storage-integrity branch June 13, 2024 06:52
Supremesource pushed a commit that referenced this pull request Sep 2, 2024
…100)

* refac: move burn related params to BurnConfig

* fix: rename removed subnets storage value

* chore: make clippy happy

* chore: add changelog

---------

Co-authored-by: saiintbrisson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants