Validate that SSM params have leading '/' #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A value like 'ssm://foo/bar' will currently get picked up as a parameter named 'foo/bar', but then the lookup in AWS will fail. These changes add a simple validation that the path has a leading '/'.
isobit
reviewed
Jun 6, 2024
Comment on lines
+191
to
+193
| if !strings.HasPrefix(*parameter, "/") { | ||
| return fmt.Errorf("SSM parameters must have a leading '/' (ssm:///<path>): %s", envvar) | ||
| } |
There was a problem hiding this comment.
I don't know. I thought the intention behind nofail was to bypass aws lookups, not validation. We've already got some other checks like this:
Lines 183 to 187 in 4cbfae7
There was a problem hiding this comment.
I guess the question is "what does nofail actually mean?"
There was a problem hiding this comment.
The arg docs say "Don't fail if error retrieving parameter", which to me implies that this should fail.
There was a problem hiding this comment.
Subjective of course but I would interpret that to mean this shouldn't fail...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A value like 'ssm://foo/bar' will currently get picked up as a parameter named 'foo/bar', but then the lookup in AWS will fail. These changes add a simple validation that the path has a leading '/'.