chore: add missing types (#214)

* chore: add missing types * cs * fix ci
rekalogika · Sep 18, 2024 · 334feb7 · 334feb7
1 parent cbf1a24
commit 334feb7
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -74,6 +74,7 @@ jobs:
     - name: Validate php-cs-fixer
       run: |
         PHP_CS_FIXER_IGNORE_ENV=1 tools/php-cs-fixer check --allow-risky=yes -q
+      if: matrix.php != '8.4'
 
     - name: Load fixtures
       run: make fixtures

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+# 0.18.1
+
+* chore: add missing types
+
 # 0.18.0
 
 * test: add phpat architecture tests

diff --git a/packages/rekapager-adapter-common/src/KeysetExpressionSQLVisitor.php b/packages/rekapager-adapter-common/src/KeysetExpressionSQLVisitor.php
@@ -37,7 +37,7 @@ final class KeysetExpressionSQLVisitor extends ExpressionVisitor
     private array $valueHashToTemplate = [];
 
     #[\Override]
-    public function walkComparison(Comparison $comparison)
+    public function walkComparison(Comparison $comparison): mixed
     {
         /** @var string */
         $value = $this->dispatch($comparison->getValue());
@@ -85,7 +85,7 @@ private function getTemplateForValue(mixed $value): string
     }
 
     #[\Override]
-    public function walkCompositeExpression(CompositeExpression $expr)
+    public function walkCompositeExpression(CompositeExpression $expr): mixed
     {
         $expressionList = [];
 

diff --git a/packages/rekapager-api-platform/src/RekapagerLinkProcessor.php b/packages/rekapager-api-platform/src/RekapagerLinkProcessor.php
@@ -37,8 +37,13 @@ public function __construct(
         private readonly ProcessorInterface $decorated,
     ) {}
 
-    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []): mixed
-    {
+    #[\Override]
+    public function process(
+        mixed $data,
+        Operation $operation,
+        array $uriVariables = [],
+        array $context = [],
+    ): mixed {
         if (
             !($request = $context['request'] ?? null)
             || !$request instanceof Request

diff --git a/packages/rekapager-doctrine-orm-adapter/src/Internal/KeysetQueryBuilderVisitor.php b/packages/rekapager-doctrine-orm-adapter/src/Internal/KeysetQueryBuilderVisitor.php
@@ -41,7 +41,7 @@ public function __construct()
     }
 
     #[\Override]
-    public function walkComparison(Comparison $comparison)
+    public function walkComparison(Comparison $comparison): mixed
     {
         /** @var mixed */
         $value = $this->dispatch($comparison->getValue());
@@ -75,7 +75,7 @@ public function walkValue(Value $value): mixed
     }
 
     #[\Override]
-    public function walkCompositeExpression(CompositeExpression $expr)
+    public function walkCompositeExpression(CompositeExpression $expr): mixed
     {
         $expressionList = [];
 

diff --git a/tests/src/App/Controller/DemoController.php b/tests/src/App/Controller/DemoController.php
@@ -32,7 +32,7 @@
 class DemoController extends AbstractController
 {
     public function __construct(
-        private PageableGenerators $pageableGenerators,
+        private readonly PageableGenerators $pageableGenerators,
     ) {}
 
     #[Route('/', name: 'index')]