chore: cs (#32)

.php-cs-fixer.dist.php

@@ -8,27 +8,22 @@
 
 $config = new PhpCsFixer\Config();
 return $config->setRules([
-    '@PSR12' => true,
-    'array_syntax' => ['syntax' => 'short'],
-
-    // imports
+    '@PER-CS2.0' => true,
+    '@PER-CS2.0:risky' => true,
     'fully_qualified_strict_types' => true,
     'global_namespace_import' => [
         'import_classes' => false,
         'import_constants' => false,
         'import_functions' => false,
     ],
-    'no_leading_import_slash' => true,
     'no_unneeded_import_alias' => true,
     'no_unused_imports' => true,
     'ordered_imports' => [
         'sort_algorithm' => 'alpha',
-        'imports_order' => ['const', 'class', 'function']
+        'imports_order' => ['class', 'function', 'const']
     ],
-    'single_line_after_imports' => true,
-    'no_useless_else' => true,
-    'no_useless_return' => true,
     'declare_strict_types' => true,
+    'native_function_invocation' => ['include' => ['@compiler_optimized']],
     'header_comment' => [
             'header' => <<<EOF
 This file is part of rekalogika/file-src package.

packages/file-association-entity/src/EmbeddedMetadata.php

@@ -75,7 +75,7 @@ private function getOther(string $key): int|string|bool|null
             $this->other = [];
         }
 
-        if (!array_key_exists($key, $this->other)) {
+        if (!\array_key_exists($key, $this->other)) {
             throw new MetadataNotFoundException($key);
         }
 
@@ -172,7 +172,7 @@ public function delete(string $key): void
             Constants::FILE_MODIFICATION_TIME => $this->modificationTime = null,
             Constants::MEDIA_WIDTH => $this->width = null,
             Constants::MEDIA_HEIGHT => $this->height = null,
-            default => $this->unsetOther($key)
+            default => $this->unsetOther($key),
         };
     }
 
@@ -187,6 +187,6 @@ public function merge(iterable $metadata): void
     #[\Override]
     public function count(): int
     {
-        return count($this->getOthers()) + 6;
+        return \count($this->getOthers()) + 6;
     }
 }

packages/file-association-entity/src/FileCollection.php

@@ -39,7 +39,7 @@ final class FileCollection extends CollectionDecorator implements DirectoryInter
      */
     public function __construct(
         Collection $files,
-        private readonly null|string|(TranslatableInterface&\Stringable) $name = null
+        private readonly null|string|(TranslatableInterface&\Stringable) $name = null,
     ) {
         parent::__construct($files);
     }

packages/file-association-entity/src/FileDecorator.php

@@ -31,7 +31,7 @@ class FileDecorator implements FileInterface
 
     public static function getFile(
         ?FileInterface $file,
-        EmbeddedMetadata $metadata
+        EmbeddedMetadata $metadata,
     ): ?FileInterface {
         if ($metadata->isFilePresent() === false) {
             // metadata says the file does not exist, and the file does not
@@ -70,7 +70,7 @@ public static function getFile(
     public static function setFile(
         ?FileInterface $input,
         ?FileInterface &$file,
-        EmbeddedMetadata $metadata
+        EmbeddedMetadata $metadata,
     ): void {
         $metadata->clear();
 
@@ -87,7 +87,7 @@ public static function setFile(
     public static function setFileMandatory(
         FileInterface $input,
         FileInterface &$file,
-        EmbeddedMetadata $metadata
+        EmbeddedMetadata $metadata,
     ): void {
         $metadata->clear();
         $file = $input;
@@ -100,9 +100,8 @@ public static function setFileMandatory(
 
     private function __construct(
         private FileInterface $file,
-        private EmbeddedMetadata $metadata
-    ) {
-    }
+        private EmbeddedMetadata $metadata,
+    ) {}
 
     //
     // other methods
@@ -115,13 +114,13 @@ public static function syncMetadata(FileInterface $file): void
     {
         if (!$file instanceof self) {
             throw new \InvalidArgumentException(
-                sprintf('"syncMetadata()" only accepts %s', static::class)
+                \sprintf('"syncMetadata()" only accepts %s', static::class),
             );
         }
 
         $file->metadata->clear();
         $file->metadata->merge(
-            $file->file->get(RawMetadataInterface::class) ?? []
+            $file->file->get(RawMetadataInterface::class) ?? [],
         );
     }
 
@@ -143,7 +142,7 @@ public function get(string $id)
 
         /** @psalm-suppress MixedReturnStatement */
         return MetadataFactory::create(
-            $this->get(RawMetadataInterface::class) ?? new RawMetadata()
+            $this->get(RawMetadataInterface::class) ?? new RawMetadata(),
         )
             ->get($id);
     }

packages/file-association-entity/src/FileMetadataDecorator.php

@@ -27,8 +27,7 @@ class FileMetadataDecorator implements RawMetadataInterface, \IteratorAggregate
     public function __construct(
         private readonly RawMetadataInterface $embeddedMetadata,
         private readonly RawMetadataInterface $fileMetadata,
-    ) {
-    }
+    ) {}
 
     #[\Override]
     public function getIterator(): \Traversable

packages/file-association-entity/src/ReadableFileCollection.php

@@ -39,7 +39,7 @@ final class ReadableFileCollection extends ReadableCollectionDecorator implement
      */
     public function __construct(
         ReadableCollection $files,
-        private readonly null|string|(TranslatableInterface&\Stringable) $name = null
+        private readonly null|string|(TranslatableInterface&\Stringable) $name = null,
     ) {
         parent::__construct($files);
     }

packages/file-association-entity/src/UnsetFile.php

@@ -33,11 +33,11 @@ class UnsetFile extends \Exception implements NullFileInterface
      */
     public function __construct(string $className, string $propertyName)
     {
-        parent::__construct(sprintf(
+        parent::__construct(\sprintf(
             'File property "%s" in class "%s" is unset. This might be caused by the use of `AbstractQuery::toIterable()`. If that is the case, you can: 1. stop involving "%s" in the query; 2. pre-hydrate the file entities before the query; or 3. use other means to iterate the query.',
             $propertyName,
             $className,
-            $className
+            $className,
         ));
     }
 

packages/file-association/src/Attribute/AsFileAssociation.php

@@ -27,7 +27,7 @@ class AsFileAssociation
     public function __construct(
         string $fetch = 'EAGER',
     ) {
-        if (!in_array($fetch, ['EAGER', 'LAZY'])) {
+        if (!\in_array($fetch, ['EAGER', 'LAZY'])) {
             throw new \InvalidArgumentException('Fetch mode can only be EAGER or LAZY.');
         }
 

packages/file-association/src/Attribute/WithFileAssociation.php

@@ -14,6 +14,4 @@
 namespace Rekalogika\File\Association\Attribute;
 
 #[\Attribute(\Attribute::TARGET_CLASS)]
-class WithFileAssociation
-{
-}
+class WithFileAssociation {}

packages/file-association/src/Contracts/FileLocationResolverInterface.php

@@ -26,6 +26,6 @@ interface FileLocationResolverInterface
 {
     public function getFileLocation(
         object $object,
-        string $propertyName
+        string $propertyName,
     ): FilePointerInterface;
 }

packages/file-association/src/Exception/FileAssociationException.php

@@ -13,6 +13,4 @@
 
 namespace Rekalogika\File\Association\Exception;
 
-abstract class FileAssociationException extends \Exception
-{
-}
+abstract class FileAssociationException extends \Exception {}

packages/file-association/src/Exception/FileLocationResolver/ChainedObjectNotSupportedException.php

@@ -21,15 +21,15 @@ class ChainedObjectNotSupportedException extends FileLocationResolverException
     public function __construct(
         object $object,
         private readonly iterable $exceptions,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         \Exception::__construct(
             \sprintf(
                 'Cannot find a resolver that supports the object "%s"',
                 $object::class,
             ),
             0,
-            $previous
+            $previous,
         );
     }
 

packages/file-association/src/Exception/FileLocationResolver/FileLocationResolverException.php

@@ -15,6 +15,4 @@
 
 use Rekalogika\File\Association\Exception\FileAssociationException;
 
-class FileLocationResolverException extends FileAssociationException
-{
-}
+class FileLocationResolverException extends FileAssociationException {}

packages/file-association/src/Exception/FileLocationResolver/ObjectNotSupportedException.php

@@ -24,17 +24,17 @@ public function __construct(
         string $class,
         object $object,
         string $message,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         parent::__construct(
             \sprintf(
                 'File location resolver "%s" does not support object "%s": %s',
                 $class,
                 $object::class,
-                $message
+                $message,
             ),
             0,
-            $previous
+            $previous,
         );
     }
 }

packages/file-association/src/Exception/ObjectIdResolver/ChainedObjectIdResolverException.php

@@ -21,15 +21,15 @@ class ChainedObjectIdResolverException extends ObjectIdResolverException
     public function __construct(
         object $object,
         private readonly iterable $exceptions,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         \Exception::__construct(
             \sprintf(
                 'None of the object ID resolvers registered in the system supports the object "%s"',
                 $object::class,
             ),
             0,
-            $previous
+            $previous,
         );
     }
 

packages/file-association/src/Exception/ObjectIdResolver/EmptyIdException.php

@@ -18,16 +18,16 @@ class EmptyIdException extends ObjectIdResolverException
     public function __construct(
         object $object,
         string $method,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         parent::__construct(
             \sprintf(
                 "Method '%s' in object '%s' returned an empty id",
                 $method,
-                $object::class
+                $object::class,
             ),
             0,
-            $previous
+            $previous,
         );
     }
 }

packages/file-association/src/Exception/ObjectIdResolver/IdNotSupportedException.php

@@ -19,17 +19,17 @@ public function __construct(
         object $object,
         string $method,
         mixed $id,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         parent::__construct(
             \sprintf(
                 'Method "%s" of object "%s" returned an unsupported identifier "%s"',
                 $method,
                 $object::class,
-                \get_debug_type($id)
+                get_debug_type($id),
             ),
             0,
-            $previous
+            $previous,
         );
     }
 }

packages/file-association/src/Exception/ObjectIdResolver/MethodNotFoundException.php

@@ -18,16 +18,16 @@ class MethodNotFoundException extends ObjectIdResolverException
     public function __construct(
         object $object,
         string $method,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         parent::__construct(
             \sprintf(
                 "Method '%s' not found in object '%s'",
                 $method,
-                $object::class
+                $object::class,
             ),
             0,
-            $previous
+            $previous,
         );
     }
 }

packages/file-association/src/Exception/ObjectIdResolver/ObjectIdResolverException.php

@@ -15,6 +15,4 @@
 
 use Rekalogika\File\Association\Exception\FileAssociationException;
 
-class ObjectIdResolverException extends FileAssociationException
-{
-}
+class ObjectIdResolverException extends FileAssociationException {}

packages/file-association/src/Exception/ObjectIdResolver/ObjectNotSupportedException.php

@@ -17,15 +17,15 @@ class ObjectNotSupportedException extends ObjectIdResolverException
 {
     public function __construct(
         object $object,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
         parent::__construct(
             \sprintf(
                 'Object "%s" is not supported.',
                 $object::class,
             ),
             0,
-            $previous
+            $previous,
         );
     }
 }

packages/file-association/src/Exception/PropertyInspector/MissingPropertyException.php

@@ -20,7 +20,7 @@ public function __construct(
         object $object,
     ) {
         parent::__construct(
-            sprintf(
+            \sprintf(
                 'Property "%s" not found in object "%s"',
                 $propertyName,
                 $object::class,

packages/file-association/src/Exception/PropertyInspector/PropertyInspectorException.php

@@ -15,6 +15,4 @@
 
 use Rekalogika\File\Association\Exception\FileAssociationException;
 
-abstract class PropertyInspectorException extends FileAssociationException
-{
-}
+abstract class PropertyInspectorException extends FileAssociationException {}

packages/file-association/src/Exception/PropertyReader/PropertyReaderException.php

@@ -20,9 +20,9 @@ class PropertyReaderException extends FileAssociationException
     public function __construct(
         object $object,
         string $property,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
-        $message = sprintf('Unable to read property "%s" in object "%s"', $property, \get_debug_type($object));
+        $message = \sprintf('Unable to read property "%s" in object "%s"', $property, get_debug_type($object));
 
         parent::__construct($message, 0, $previous);
     }

packages/file-association/src/Exception/PropertyWriter/PropertyWriterException.php

@@ -24,9 +24,9 @@ public function __construct(
         object|array $object,
         string $property,
         mixed $value,
-        \Throwable $previous = null
+        \Throwable $previous = null,
     ) {
-        $message = sprintf('Unable to write "%s" to property "%s" in object "%s"', \get_debug_type($value), $property, \get_debug_type($object));
+        $message = \sprintf('Unable to write "%s" to property "%s" in object "%s"', get_debug_type($value), $property, get_debug_type($object));
 
         parent::__construct($message, 0, $previous);
     }