Merge pull request #78 from regulaforensics/fix/sp-12517

SP-12517 -methods without arguments guard
regulaforensics · Nov 23, 2023 · ba267df · ba267df
2 parents a6b8bca + 670d7f4
commit ba267df
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/ext/group-api.ts b/src/ext/group-api.ts
@@ -10,7 +10,11 @@ export class GroupApi {
     }
 
     async createGroup(groupToCreate: GroupToCreate, xRequestID?: string, options?: AxiosRequestConfig): Promise<Group> {
-        const response = await this.superClass.createGroup(groupToCreate, xRequestID, options);
+        const groupToCreateWithGuard = {
+            ...groupToCreate,
+            metadata: !groupToCreate?.metadata ? {} : groupToCreate.metadata
+        }
+        const response = await this.superClass.createGroup(groupToCreateWithGuard, xRequestID, options);
         return response.data;
     }
 

diff --git a/src/ext/person-api.ts b/src/ext/person-api.ts
@@ -11,7 +11,11 @@ export class PersonApi {
     }
 
     async createPerson(personFields: PersonFields, xRequestID?: string, options?: AxiosRequestConfig): Promise<Person> {
-        const response = await this.superClass.createPerson(personFields, xRequestID, options);
+        const personFieldsWithGuard = {
+            ...personFields,
+            metadata: !personFields?.metadata ? {} : personFields.metadata
+        }
+        const response = await this.superClass.createPerson(personFieldsWithGuard, xRequestID, options);
         return response.data;
     }
     async addImageToPerson(