fix: dont start session service starting targets #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that starting regolith-wayland.target and regolith-x11.target doesn't automatically start their corresponding services. However, the targets are still started with their corresponding services, for which regolith-x11.service and regolith-wayland.service are made into the entry points for the session. These changes also establish a stronger dependency between service files and target files using the `BindsTo` directive, such that the lifecycle of regolith-wayland.service and regolith-x11.service is dependent on regolith-wayland.target and regolith-x11.target. This implies, starting the services starts the targets and the service then responds to lifecycle of the target, including restart and stop. But starting the target won't start the service. Fixes: #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that starting regolith-wayland.target and regolith-x11.target doesn't automatically start their corresponding services. However, the targets are still started with their corresponding services, for which regolith-x11.service and regolith-wayland.service are made into the entry points for the session.
These changes also establish a stronger dependency between service files and target files using the
BindsTodirective, such that the lifecycle of regolith-wayland.service and regolith-x11.service is dependent on regolith-wayland.target and regolith-x11.target. This implies, starting the services starts the targets and the service then responds to lifecycle of the target, including restart and stop. But starting the target won't start the service.Fixes: #36