-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use systemd instead of gnome-session's builtin session management #31
Conversation
systemd automatically loads environment.d
Let systemd handle process management
The sway session works with this patch on matic. I can't say the same for the X11 session (it's broken for some unknown reason on my system). |
Impressive work @SoumyaRanjanPatnaik . Do you think this will remain backwards compatible to debian bullseye and ubuntu focal? |
It should, as long as the version |
Although I did like your refactor of the session files. It simplifies the session files and is way cleaner. We can probably merge the two branches. |
I'm working on this today because I decided to upgrade my dev machine to 24.04 and things didn't go so well. 🤣 I've tested my version in that the i3 and sway desktops load from gdm3. There is some weirdness related to the session tho for things like logout, reboot, etc.. I'm guessing your systemd approach is the cleaner and more maintainable refactor. Will do some testing. |
Unable to reach sway desktop from login after installing
I've only built the package for |
Can you check the output of |
Also I was having to reboot for the first time. |
I am running the default
|
Alright I know the issue. |
Verified no change (fail state) after reboot |
I had added support for configuring custom environments using systemd. Its probably searching for the env file at |
ExecStart=regolith-session-wayland | ||
|
||
# Setup custom environment for session | ||
EnvironmentFile=%h/.config/regolith3/sway/env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this guy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Just pushed a fix
Should be fixed now |
build attempt: https://github.com/regolith-linux/voulage/actions/runs/8769279314 |
Verified fix. I am able to reach both i3 and sway desktops w/ |
Thanks :). Kinda surprised there aren't any issues with the X11 session. In my experience the startup and logout time has improved significantly as well. |
Lmk if you need help with anything. I have some time on my hands this weekend. |
Nice :) I'll be testing, working towards a first beta of 3.2 to (hopefully) closely follow the upstream Ubuntu release. So, any docs that need to be added or specific things to test, last minute tweaks for 3.2...now is the time. |
|
Just wondering. Do we finally promote Wayland to stable? |
I'm also thinking of always starting sway with the |
SGTM!
Is there no downside? (there's always a downside) |
Can you quickly check the sitch with regolith-linux/regolith-wm-config#14 given this systemd change @SoumyaRanjanPatnaik ? |
There's a chance they even the contents of |
Seems like it. My laptop uses AMD graphics with the open source drivers.(Supported). I recently realised that I've had this option enabled for the past one year. Haven't had any problems. |
The only downside might be us having to deal with display flickering/no output issues, which are actually due to the lack of NVidia support on sway. But keeping NVidia behind a flag that users don't know exists already brings up at least as many issues, if not more. |
We can create another "Call for features and issues" discussion to get a definitive idea of whether users are having a good experience or not. |
gnome-session
removes the--builtin
and--systemd
flags with v46 . The default behaviour now requires the sessions to use systemd.Fixes regolith-linux/regolith-desktop#1001
Requires regolith-linux/regolith-wm-config#24