Display oldest notifications first by default

[dferrand]

In response to regolith-linux/regolith-desktop#607 I changed rofication-daemon to reverse notification list order (to display the newest notification first) by default.

Previous behaviour (oldest notification first) can be restored by setting i3xrocks.oldest.first to true in Xresources.

[dferrand]

I made the notification sort more flexible, it is now possible to sort notification on multiple fields.

Sort order is indicated in i3xrocks.notify.sort.by as a space separated list of fields. If a field name is preceded by ! it is considered a descending sort order. Default sort order is "!timestamp". Previous order can now restored by setting sort order to "timestamp".

Another useful sort order could be "!urgency !timestamp" to have notifications sorted by urgency (more urgent first) then by timestamp (newest first).

[cfsmp3]

I made the notification sort more flexible, it is now possible to sort notification on multiple fields.

LGTM but this should be documented somewhere other than here :-) [suggestion: Website + config template]

[dferrand]

LGTM but this should be documented somewhere other than here :-) [suggestion: Website + config template]

Good point, I created regolith-linux/website#160 for website documentation.

I'm not sure what a config template is.

[cfsmp3]

I'm not sure what a config template is.

https://github.com/regolith-linux/regolith-i3-gaps-config/blob/master/config

I think have the default there listed explicitly is a good idea.
BTW I think Xresources is going away (it was removed from the newest i3). I could be wrong though @kgilmer

[dferrand]

https://github.com/regolith-linux/regolith-i3-gaps-config/blob/master/config

This is the i3 config file, I do not change anything there, only Xresources.

[cfsmp3]

https://github.com/regolith-linux/regolith-i3-gaps-config/blob/master/config

This is the i3 config file, I do not change anything there, only Xresources.

I know; I suggest that you do actually modify that file so that it contains the default for the new setting.

[cfsmp3]

This will crash if there's a typo in the field and it doesn't exist in the message.

A possibility would be, rather than crashing, returning a list with a single message reporting the error (something like "Field XX does not exist, check i3xrocks_notify_sort_by in XResource. Valid fields are....)

[dferrand]

I updated the code. Now if an incorrect field name is used, a message indicating that is added at the top of the list and the rest of the sorting is done normally.

[kgilmer]

Thank you @dferrand , very nice PR. Can you explain a bit about how you tested this change? How will users know what values they can provide for the sort field?

[dferrand]

r

Thank you @dferrand , very nice PR. Can you explain a bit about how you tested this change? How will users know what values they can provide for the sort field?

I tested manually on my system by killing the "normal" regolith-rofication process and launching the dev one instead.

Technically you can sort on any field of the Notification class (defined in rofication/_notification.py) but I don't see much practical use to sort on anything but timestamp and urgency. How would you suggest to let the user know the possible fields?

[kgilmer]

Sorry for the delay.

How would you suggest to let the user know the possible fields?

We'll just need to document it on the website. This is the page and this is the markdown file that can include the details