Fallible Wasm Module for testing #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwample
added
documentation
|
This is likely dependent on #8 to allow for configurable failures in the places that I would like them to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a wasm module that takes in a config indicating one of several internal failures that an implemented web assembly binary might encounter. This will be useful in integration tests for all different client languages as the internal failure modes that the client must gracefully handle are consistent.
At the same time this PR may make changes to the internal interfaces and layout to make the use of sync / async WebAssembly Modules more modular and the independent errors clearer.
In general we need to start drawing a more clear line around what we provide for in the wasm library and what developers should write. This can include varying degrees of involvement from Encode / Decode /Config all the way down to the raw WATER API, and we can provide trait boundaries and wrappers at the various levels of abstraction.