v0 (plus) API and spec #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note: I think this PR will be ready to merge once the following problems are addressed:
|
gaukas
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
The V0-related changes and the version-independent portion look good to me! Thanks for your great effort in implementing this!
Besides the clarification requested on two potentially duplicated files, this PR looks good to me at the current state and I approve the proposed change.
…r plain implementation [ci skip]
gaukas
approved these changes
Nov 29, 2023
…TM-v0 (credits to @gaukas)
…(dns query) for the bypassed-ss-watm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to match our design for v0+, and resolve this issue #3
.wasmbinaryBug reproduce and potential fix<- not yet seen in Rust side