Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dependabot auto PR #26

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Enable Dependabot auto PR #26

merged 2 commits into from
Jan 27, 2024

Conversation

erikziyunchi
Copy link
Member

Try to resolve the issue #25.

sourcery-ai[bot]

This comment was marked as outdated.

Copy link
Contributor

@gaukas gaukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to be and I am approving to unblock the merging. But kindly check out my concerns below:

  • I think this PR tries to enable "Dependabot version updates", which does more than "Dependabot security updates" (configurable in repository settings). Which is Okay.
  • Not sure if enabling it would really benefit the maintenance of this project. Do you expect expected or reduced workload in maintaining dependency updates with it?
  • I'm asking ONLY because I see we are using a few unstable (v0.x) packages and uncertain about how many of them may break the backward compatibility when being updated.

@erikziyunchi
Copy link
Member Author

Thanks for the approval and notes! Yeah, I think your concerns are absolutely valid, I'm having the similar concerns as well. But it seems like this will be the best way to keep track with all the packages we are using(and should fix most of the security concerns), some updates might break the compatibility and some of the auto PR might need some manual changes to the code, especially with wasmtime related updates, so I currently set them as ignored and update manually later.

@erikziyunchi erikziyunchi merged commit 8d39311 into main Jan 27, 2024
6 checks passed
@erikziyunchi erikziyunchi deleted the enable-dependabot branch January 27, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants