Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Showcase PR] ShadowSocks patch to prove the ability of seamless update #14

Closed
wants to merge 1 commit into from

Conversation

erikziyunchi
Copy link
Member

Earlier this year, China has started to block fully encrypted protocols, and @gfw-report has published a patch for modifying SS to mitigate this problem.

This PR is a showcase where how easy and seamless this patch can be implemented in W.A.T.E.R. just like patching on the official shadowsocks_rust.

@erikziyunchi
Copy link
Member Author

Probably leave lint as it, since those are the exact changes from the patch where we want to show that no additional work needed in our implementation.

@gaukas
Copy link
Contributor

gaukas commented Oct 31, 2023

If it breaks lint, I think we'd better keep it in a separate branch for now. This will fulfills our purpose of showing the patch without making the major parts of our repo seem broken.

@erikziyunchi
Copy link
Member Author

Yeah, this is what I was thinking as well. Since it will also be hard to test where we need to spawn a local ShadowSocks server with the corresponding patch to make it encrypt & decrypt correctly.

@erikziyunchi erikziyunchi added the showcase Showcase of changes label Oct 31, 2023
@erikziyunchi erikziyunchi changed the title ShadowSocks patch to prove the ability of seamless update [Showcase PR] ShadowSocks patch to prove the ability of seamless update -- may not merge for now Nov 5, 2023
@erikziyunchi
Copy link
Member Author

This is a showcase PR which demonstrate the same patch for shadowsocks-rust can be applied to WATER will not be merged. For more details look at the first comment.

@erikziyunchi erikziyunchi changed the title [Showcase PR] ShadowSocks patch to prove the ability of seamless update -- may not merge for now [Showcase PR] ShadowSocks patch to prove the ability of seamless update Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Showcase of changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants