WIP: Add support for Mobility #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gloubier
reviewed
Apr 27, 2018
| @@ -1,22 +1,17 @@ | |||
| class TranslatePageImageCaptions < ActiveRecord::Migration[4.2] | |||
| def up | |||
| add_column Refinery::ImagePage.table_name, :id, :primary_key | |||
There was a problem hiding this comment.
Removing this causes an Unknown primary key for table refinery_image_pages in model Refinery::ImagePage. error.
There was a problem hiding this comment.
It should not because i've made this change too : https://github.com/refinery/refinerycms-page-images/pull/149/files#diff-cfa073f65992007a3d91e1efad7b811bL3
Because page images could be added to other extensions than pages
This will temp. fix bundler issue in Travis
bricesanchez
force-pushed
the
feature/mobility
branch
2 times, most recently
from
a62df69
to
7a9d50b
Compare
bricesanchez
force-pushed
the
feature/mobility
branch
from
53a3a47
to
6032bd2
Compare
…tiple entries on a page
|
@bricesanchez How far away is this from being usable? With the rest of Refinery successfully migrated to Mobility, it's a bit of a shame that this gem is stuck in the past. I've never used Mobility before, so I don't think I can help much, but maybe I can do some lo-fi manual testing or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.